itarakanov commented on a change in pull request #367:
URL: https://github.com/apache/curator/pull/367#discussion_r442344391
##########
File path:
curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceCacheImpl.java
##########
@@ -163,9 +164,19 @@ public void removeListener(ServiceCacheListener listener)
discovery.getClient().getConnectionStateListenable().removeListener(listener);
}
+ private boolean isRootPathEvent(PathChildrenCacheEvent event) {
Review comment:
I would rather call it something like **isEmptyPathEvent**, because
"root" is a relative thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
