[
https://issues.apache.org/jira/browse/CURATOR-582?focusedWorklogId=474054&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-474054
]
ASF GitHub Bot logged work on CURATOR-582:
------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Aug/20 21:05
Start Date: 24/Aug/20 21:05
Worklog Time Spent: 10m
Work Description: tamaashu commented on a change in pull request #372:
URL: https://github.com/apache/curator/pull/372#discussion_r475893740
##########
File path: curator-client/src/test/java/org/apache/curator/BasicTests.java
##########
@@ -30,15 +37,13 @@
import org.apache.zookeeper.ZooDefs;
import org.apache.zookeeper.ZooKeeper;
import org.mockito.Mockito;
-import org.testng.Assert;
-import org.testng.annotations.Test;
import java.util.concurrent.Callable;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.atomic.AtomicBoolean;
public class BasicTests extends BaseClassForTests
{
- @Test
+ @RepeatedIfExceptionsTest(repeats = BaseClassForTests.REPEATS)
Review comment:
There are multiple ways to repeat failed tests with jUnit5.
Most simple is Maven's surefire plugin, which works now with jUnit5.
But in Curator in the original solution not all of the tests have been
repeated when failed. Some of them have been tried only once, some not.
This extension provides an annotation which you can use on those tests which
you want to repeat when failed, but still have the option to use @Test on those
you are not interested in. I thinks this greater flexibility is valuable.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 474054)
Time Spent: 50m (was: 40m)
> Migrate to jUnit 5.6
> --------------------
>
> Key: CURATOR-582
> URL: https://issues.apache.org/jira/browse/CURATOR-582
> Project: Apache Curator
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 5.1.0
> Reporter: Tamas Penzes
> Priority: Major
> Labels: junit5
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Most related components use jUnit and slowly migrate to jUnit 5.
> Curator uses TestNG, which was superior to jUnit4, but looks like jUnit 5 got
> over it.
> It's time to go forward and migrate to jUnit 5.6 just as ZooKeeper did.
> I'll create subtasks and work on them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
