[
https://issues.apache.org/jira/browse/CURATOR-582?focusedWorklogId=477497&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-477497
]
ASF GitHub Bot logged work on CURATOR-582:
------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Sep/20 22:29
Start Date: 01/Sep/20 22:29
Worklog Time Spent: 10m
Work Description: cammckenzie commented on a change in pull request #372:
URL: https://github.com/apache/curator/pull/372#discussion_r481467437
##########
File path: curator-client/src/test/java/org/apache/curator/BasicTests.java
##########
@@ -30,15 +37,13 @@
import org.apache.zookeeper.ZooDefs;
import org.apache.zookeeper.ZooKeeper;
import org.mockito.Mockito;
-import org.testng.Assert;
-import org.testng.annotations.Test;
import java.util.concurrent.Callable;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.atomic.AtomicBoolean;
public class BasicTests extends BaseClassForTests
{
- @Test
+ @RepeatedIfExceptionsTest(repeats = BaseClassForTests.REPEATS)
Review comment:
I agree that not having to annotate every test is a good idea. If this
functionality can be provided by configuration at a higher level that sounds
like a good approach to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 477497)
Time Spent: 1h 20m (was: 1h 10m)
> Migrate to jUnit 5.6
> --------------------
>
> Key: CURATOR-582
> URL: https://issues.apache.org/jira/browse/CURATOR-582
> Project: Apache Curator
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 5.1.0
> Reporter: Tamas Penzes
> Priority: Major
> Labels: junit5
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Most related components use jUnit and slowly migrate to jUnit 5.
> Curator uses TestNG, which was superior to jUnit4, but looks like jUnit 5 got
> over it.
> It's time to go forward and migrate to jUnit 5.6 just as ZooKeeper did.
> I'll create subtasks and work on them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
