jmslocum16 commented on a change in pull request #376:
URL: https://github.com/apache/curator/pull/376#discussion_r570598006
##########
File path:
curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java
##########
@@ -642,6 +657,10 @@ else if ( (rc ==
KeeperException.Code.NODEEXISTS.intValue()) && setDataIfExists
{
backgroundSetData(client, operationAndData,
operationAndData.getData().getPath(), backgrounding);
}
+ else if ( (rc ==
KeeperException.Code.NODEEXISTS.intValue()) && idempotent &&
!createMode.isSequential() )
Review comment:
Actually, after thinking about this some more, and reading the zookeeper
documentation, I don't think it's possible to get a NODE_EXISTS exception with
sequential creates (which makes sense now that I think about it):
https://zookeeper.apache.org/doc/r3.3.3/api/org/apache/zookeeper/ZooKeeper.html#create(java.lang.String,%20byte[],%20java.util.List,%20org.apache.zookeeper.CreateMode)
So I just removed the check for createMode.isSequential() entirely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
