TisonKun commented on a change in pull request #376:
URL: https://github.com/apache/curator/pull/376#discussion_r573012387
##########
File path:
curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java
##########
@@ -87,6 +93,7 @@ public CreateBuilderImpl(CuratorFrameworkImpl client,
CreateMode createMode, Bac
this.createParentsAsContainers = createParentsAsContainers;
this.compress = compress;
this.setDataIfExists = setDataIfExists;
+ this.idempotent = false;
Review comment:
ditto
##########
File path:
curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java
##########
@@ -74,6 +79,7 @@
createParentsAsContainers = false;
compress = false;
setDataIfExists = false;
+ idempotent = false;
Review comment:
if we have a default value, then this is redundant.
##########
File path:
curator-framework/src/main/java/org/apache/curator/framework/imps/SetDataBuilderImpl.java
##########
@@ -36,13 +39,22 @@
private Backgrounding backgrounding;
private int version;
private boolean compress;
+ private boolean idempotent = false;
+
+ @VisibleForTesting
+ boolean failNextSetForTesting = false;
+ @VisibleForTesting
+ boolean failBeforeNextSetForTesting = false;
+ @VisibleForTesting
+ boolean failNextIdempotentCheckForTesting = false;
SetDataBuilderImpl(CuratorFrameworkImpl client)
{
this.client = client;
backgrounding = new Backgrounding();
version = -1;
compress = false;
+ idempotent = false;
Review comment:
ditto
##########
File path:
curator-framework/src/main/java/org/apache/curator/framework/imps/SetDataBuilderImpl.java
##########
@@ -51,6 +63,7 @@ public SetDataBuilderImpl(CuratorFrameworkImpl client,
Backgrounding backgroundi
this.backgrounding = backgrounding;
this.version = version;
this.compress = compress;
+ this.idempotent = false;
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
