martin-g commented on a change in pull request #409:
URL: https://github.com/apache/curator/pull/409#discussion_r814820951
##########
File path:
curator-framework/src/test/java/org/apache/curator/framework/state/TestConnectionStateManager.java
##########
@@ -92,6 +94,7 @@ public void stateChanged(CuratorFramework client,
ConnectionState newState)
@Test
public void testConnectionStateRecoversFromUnexpectedExpiredConnection()
throws Exception {
+ assumeTrue(() -> (getMajor() == 3 && getMinor() >= 6) || (getMajor() >
4), "Zookeeper version must be 3.6 or higher");
Review comment:
This does not really work...
It seems javac inlines the values of the constants and the test still prints
`3` and `6` even for `curator-test-zk35` modole.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
