tisonkun commented on a change in pull request #409:
URL: https://github.com/apache/curator/pull/409#discussion_r815245892
##########
File path:
curator-framework/src/test/java/org/apache/curator/framework/state/TestConnectionStateManager.java
##########
@@ -91,7 +92,10 @@ public void stateChanged(CuratorFramework client,
ConnectionState newState)
}
@Test
- public void testConnectionStateRecoversFromUnexpectedExpiredConnection()
throws Exception {
+ void testConnectionStateRecoversFromUnexpectedExpiredConnection() throws
Exception {
Review comment:
Another perspective is that whether or not we won't to test that it's
zk35compatible. If we don't intend to do that, we can move the test to another
(new) class and assign it to zk36 group.
##########
File path:
curator-framework/src/test/java/org/apache/curator/framework/state/TestConnectionStateManager.java
##########
@@ -91,7 +92,10 @@ public void stateChanged(CuratorFramework client,
ConnectionState newState)
}
@Test
- public void testConnectionStateRecoversFromUnexpectedExpiredConnection()
throws Exception {
+ void testConnectionStateRecoversFromUnexpectedExpiredConnection() throws
Exception {
Review comment:
Another perspective is that whether or not we want to test that it's
zk35compatible. If we don't intend to do that, we can move the test to another
(new) class and assign it to zk36 group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
