tisonkun commented on a change in pull request #409:
URL: https://github.com/apache/curator/pull/409#discussion_r815376906
##########
File path:
curator-framework/src/test/java/org/apache/curator/framework/state/TestConnectionStateManager.java
##########
@@ -91,7 +92,10 @@ public void stateChanged(CuratorFramework client,
ConnectionState newState)
}
@Test
- public void testConnectionStateRecoversFromUnexpectedExpiredConnection()
throws Exception {
+ void testConnectionStateRecoversFromUnexpectedExpiredConnection() throws
Exception {
+ final int major = getVersionPart("MAJOR");
+ final int minor = getVersionPart("MINOR");
+ assumeTrue(major == 3 && minor >= 6 || major > 4, "Zookeeper version
must be 3.6 or higher");
Review comment:
Also, the boolean condition should not be `==3 || > 4`, what if `==4`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
