jira-importer commented on issue #524: URL: https://github.com/apache/curator/issues/524#issuecomment-2604690561
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=githubbot";>githubbot</a>:</i> <p>GitHub user lvfangmin opened a pull request:</p> <p> <a href="https://github.com/apache/curator/pull/210"; class="external-link" target="_blank" rel="nofollow noopener">https://github.com/apache/curator/pull/210</a></p> <p> upgrade clirr to fix the check error on java 8</p> <p> Currently, the `mvn compile` failed on <a href="https://issues.apache.org/jira/browse/CURATOR-3"; title="LeaderLatch race condition causing extra nodes to be added in Zookeeper Edit" class="issue-link" data-issue-key="CURATOR-3"><del>CURATOR-3</del></a>.0 branch, it turns out clirr maven plugin has bug and can fail on Java 8, the latest 2.8 version fixed those bug, and compiled without error.</p> <p> Error details:<br/> -------------------<br/> <span class="error">[ERROR]</span> Failed to execute goal org.codehaus.mojo:clirr-maven-plugin:2.6.1:check (default) on project curator-x-async: Execution default of goal org.codehaus.mojo:clirr-maven-plugin:2.6.1:check failed: Invalid byte tag in constant pool: 15</p> <p>You can merge this pull request into a Git repository by running:</p> <p> $ git pull <a href="https://github.com/lvfangmin/curator"; class="external-link" target="_blank" rel="nofollow noopener">https://github.com/lvfangmin/curator</a> upgrade_clirr</p> <p>Alternatively you can review and apply these changes as the patch at:</p> <p> <a href="https://github.com/apache/curator/pull/210.patch"; class="external-link" target="_blank" rel="nofollow noopener">https://github.com/apache/curator/pull/210.patch</a></p> <p>To close this pull request, make a commit to your master/trunk branch<br/> with (at least) the following in the commit message:</p> <p> This closes #210</p> <hr /> <p>commit ea36769afa77b510e2206d34faed17e6f4a57bd3<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-09-23T13:21:35Z</p> <p> Merge branch 'master' into <a href="https://issues.apache.org/jira/browse/CURATOR-3"; title="LeaderLatch race condition causing extra nodes to be added in Zookeeper Edit" class="issue-link" data-issue-key="CURATOR-3"><del>CURATOR-3</del></a>.0</p> <p>commit 2c0fca86ca3c25c9777e1b5c3bb3eea6cb0be8da<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-09-26T00:14:53Z</p> <p> interim work - updated APIs make sure old tests work</p> <p>commit afa8f7a45b1cc154317ac757d20340ce26b9cdab<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-09-26T00:19:05Z</p> <p> Merge branch '<a href="https://issues.apache.org/jira/browse/CURATOR-3"; title="LeaderLatch race condition causing extra nodes to be added in Zookeeper Edit" class="issue-link" data-issue-key="CURATOR-3"><del>CURATOR-3</del></a>.0' into <a href="https://issues.apache.org/jira/browse/CURATOR-261"; title="ZooKeeper 3.5.x has enough APIs so that Javassist can be removed" class="issue-link" data-issue-key="CURATOR-261"><del>CURATOR-261</del></a></p> <p>commit 4c3c8377935f8ae2c0f24c4a1010cf4bdef4e297<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-09-26T00:22:10Z</p> <p> Merge branch '<a href="https://issues.apache.org/jira/browse/CURATOR-3"; title="LeaderLatch race condition causing extra nodes to be added in Zookeeper Edit" class="issue-link" data-issue-key="CURATOR-3"><del>CURATOR-3</del></a>.0' into <a href="https://issues.apache.org/jira/browse/CURATOR-265"; title="Dynamic Reconfig APIs needs some work and more accurate testing" class="issue-link" data-issue-key="CURATOR-265"><del>CURATOR-265</del></a></p> <p> Conflicts:<br/> curator-framework/src/test/java/org/apache/curator/framework/imps/TestReconfiguration.java</p> <p>commit d42ef172e57af17ed42d7c2c4e2d9a7a0c520f3c<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-09-26T02:07:44Z</p> <p> wip - adding() API was misnamed. Also, it's mutually exclusive with join/leave</p> <p>commit 36ddd58a31045addfd9d984353956f7a99c09221<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-09-26T02:49:12Z</p> <p> finalized the changes and removed old classes</p> <p>commit e09388a5a7cc131643d685fd8efff64da15e168b<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-09-26T03:00:37Z</p> <p> missed a few</p> <p>commit a8ec17ece060484e0e6ce723568ed9505f6b82ef<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-09-26T03:05:43Z</p> <p> Fixed newMembers test</p> <p>commit 2ff89856d6ee2d373cf91bc1a3bd388890604373<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-09-26T04:59:47Z</p> <p> enforce single thread</p> <p>commit c1084663aa8991a06cc7390180d07cbaf6c330e1<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-09-26T14:15:54Z</p> <p> License header</p> <p>commit a7076bc8dd806bb824e33dcd2f8b5e53626b5691<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-09-26T15:03:20Z</p> <p> better test - shouldn't fail if slow</p> <p>commit 26364c6186fc7c09a9462557b1ca791e9aa70006<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-09-26T18:13:02Z</p> <p> 1. EnsembleTracker should always be on, it now is<br/> 2. Removed DynamicEnsembleProvider. This should not be optional. EnsembleTracker now always publishes config changes which will end up calling ZooKeeper.updateServerList()<br/> 3. Testing</p> <p>commit 56d9ba665ef69944ef0ab9c65aa014b921fd39f9<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-09-26T18:59:35Z</p> <p> Added doc regarding EnsembleTracker</p> <p>commit 6e56e8ae9f04ffdd76505858dbbe5b1ff04dbd49<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-09-26T23:03:06Z</p> <p> ExhibitorEnsembleProvider is not compatible with updateServerList()</p> <p>commit 2827ba81b5c66ec4f864cc2e3582776e955158ac<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-09-26T23:07:10Z</p> <p> fixed compile error</p> <p>commit cb34e6f6a41b08c9d4e6179d9f893b0e48e7860c<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-09-27T18:31:32Z</p> <p> continued work on tests, etc.</p> <p>commit b89091e9363e760aa34028bcfb57baf6ca921957<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-10-02T14:37:13Z</p> <p> Support getting at the cached config from the ensemble tracker</p> <p>commit add56dc92e4564ce5d146a8f3c0a8ae51c6dc46f<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-10-02T22:22:48Z</p> <p> Support delete().quietly() and create().orSetData()</p> <p>commit 537156db46becd67542a653d6ab055168ed507d0<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-10-06T01:27:46Z</p> <p> for some reason, one of the constructors got messed up</p> <p>commit df949e7a27e370d0e7f8013a7c7b0469382d1a2f<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-10-06T13:23:41Z</p> <p> Merge branch 'master' into <a href="https://issues.apache.org/jira/browse/CURATOR-3"; title="LeaderLatch race condition causing extra nodes to be added in Zookeeper Edit" class="issue-link" data-issue-key="CURATOR-3"><del>CURATOR-3</del></a>.0</p> <p>commit 0fe4d969f86836ecfcf27ab1164c422e771d1495<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-10-09T00:09:13Z</p> <p> Merge branch '<a href="https://issues.apache.org/jira/browse/CURATOR-3"; title="LeaderLatch race condition causing extra nodes to be added in Zookeeper Edit" class="issue-link" data-issue-key="CURATOR-3"><del>CURATOR-3</del></a>.0' into <a href="https://issues.apache.org/jira/browse/CURATOR-265"; title="Dynamic Reconfig APIs needs some work and more accurate testing" class="issue-link" data-issue-key="CURATOR-265"><del>CURATOR-265</del></a></p> <p>commit 779ff5ea459ce8d60c92db1c3fde2966d1cc3e3a<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-10-09T00:11:56Z</p> <p> Merge branch '<a href="https://issues.apache.org/jira/browse/CURATOR-3"; title="LeaderLatch race condition causing extra nodes to be added in Zookeeper Edit" class="issue-link" data-issue-key="CURATOR-3"><del>CURATOR-3</del></a>.0' into <a href="https://issues.apache.org/jira/browse/CURATOR-266"; title="Support updateServerList" class="issue-link" data-issue-key="CURATOR-266"><del>CURATOR-266</del></a></p> <p> Conflicts:<br/> curator-framework/src/main/java/org/apache/curator/framework/imps/NamespaceFacade.java</p> <p>commit 198179ca8e6b08c49d786896b9d7fb83c3b78608<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-10-09T14:49:05Z</p> <p> make git tag HEAD</p> <p>commit 967faf123243b052ea01762ad55ace61ab39d15c<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-10-10T20:15:27Z</p> <p> remove calls to deprecated client.clearWatcherReferences()</p> <p>commit b25a8a35856abf9710d42fae0a7324fbe66c362d<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-10-10T20:15:50Z</p> <p> Trying to make tests more reliable</p> <p>commit 34700a0557672061ecc859b8b129e40b3f5c244e<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-10-10T21:49:06Z</p> <p> don't do work if client is closed</p> <p>commit 208317ab0110663745a5e8e76fd9a8bca634082e<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-10-10T21:49:33Z</p> <p> Trying to make tests more reliable</p> <p>commit ff3fbd759879e677f84b9628b1f2f4a91c3d521d<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-10-10T21:51:15Z</p> <p> Removed testChildReaperCleansUpLockNodes() as the Reaper is now deprecated</p> <p>commit a0cb3fa7fc5cfbfe6c596ff1b890864ed421fa92<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-10-11T15:44:38Z</p> <p> Remove retry logic. It doesn't work correctly anyway. Maybe revisit later</p> <p>commit b7cfbb64a10526a612f87a00f62e32d08b5da411<br/> Author: randgalt <randg...@apache.org><br/> Date: 2015-10-11T15:45:39Z</p> <p> Don't fail on unexpected event. It's not actually a failure</p> <hr /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
