jira-importer commented on issue #524: URL: https://github.com/apache/curator/issues/524#issuecomment-2604690568
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=tison">tison</a>:</i> <p>After some reasoning I think this issue won't happen in 5.2.1.</p> <ol> <li>close is synchronized and it will first set state to CLOSE and then setNode(null);</li> <li>reset() is not synchronized and it may create node after close is called.</li> </ol> <p>However,</p> <ol> <li>If reset() creates new node, it will check state before getChildren.</li> <li>If state is CLOSE now, then the node will be removed.</li> <li>If state is still START, then later close will call setNode(null) and remove the node.</li> </ol> <p>Another possible race case is about setLeadership, but since it's synchronized, setLeadership(true) later then close() will not notify any listener since they're removed from close().</p> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org