jira-importer commented on issue #535: URL: https://github.com/apache/curator/issues/535#issuecomment-2604692370
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=iocanel";>iocanel</a>:</i> <p>I am attaching a second draft of the patch.</p> <p>There are still things need to be done, but I'd like some feedback/guidelines.</p> <p>The patch modifies the NamespaceWatcherMap and adds it some pooling characteristics (a borrow and release method backed by an array list).</p> <p>The main issue I have is when to "borrow" and when to "release":</p> <p>i) Having the recipes do the "borrow" and "release" in some cases is not enough as not always is obvious when to "release". <br/> ii) Releasing when the watcher processes the event again is not enough, as I think that curator may reuse Watcher instance again in some cases (not 100% sure).<br/> iii) "borrow" inside the Watching getWatcher() seems like a good idea but then again its not easy to "release".</p> <p>Thoughts?</p> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
