jira-importer commented on issue #535: URL: https://github.com/apache/curator/issues/535#issuecomment-2604692381
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=randgalt">randgalt</a>:</i> <p>comments:</p> <ul> <li>WatcherMap should extend Closeable</li> <li>JavaDoc @return on WatcherMap is empty</li> <li>Why is WatcherMap.get() parameterized? Shouldn't it just return Watcher?</li> <li>NamespaceWatcher.warp() is misspelled</li> <li>DistributedDoubleBarrier.acutalWatcher is misspelled</li> <li>I think that WatcherMap should introduce a new Interface other than re-using Watcher. It's a bit confusing to use a ZooKeeper Watcher as a key. Maybe a new interface called WatcherKey or something. I realize that this is how I had it but now that it's getting distributed throughout the code base I can see that it's confusing. This will also prevent a bad watcher from getting passed to Curator/ZooKeeper.</li> <li>Why is LockInternals.internalWatcherMap needed?</li> </ul> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org