Re: [I] [CURATOR-67] Issue with default JSONInstanceSerializer for discovery service builder [curator]

[via GitHub]

jira-importer commented on issue #588:
URL: https://github.com/apache/curator/issues/588#issuecomment-2604700854

   <i><a 
href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ddiod...@successfactors.com";>ddiod...@successfactors.com</a>:</i>
   <p>Adding the patch to fix the issue can someone check in this fix ?</p>
   
   
   
   <p>diff --git 
a/curator-x-discovery/src/main/java/org/apache/curator/x/discovery/ServiceDiscoveryBuilder.java
 b/curator-x-discovery/src/main/java/org/apache/curator/x/d<br/>
   index ab62004..d464a55 100644<br/>
   &#8212; 
a/curator-x-discovery/src/main/java/org/apache/curator/x/discovery/ServiceDiscoveryBuilder.java<br/>
   +++ 
b/curator-x-discovery/src/main/java/org/apache/curator/x/discovery/ServiceDiscoveryBuilder.java<br/>
   @@ -29,6 +29,7 @@ public class ServiceDiscoveryBuilder<T><br/>
        private String  basePath;<br/>
        private InstanceSerializer<T>   serializer;<br/>
        private ServiceInstance<T>      thisInstance;<br/>
   +    private Class<T>payloadClass;</p>
   
   <p>     /**</p>
   <ul>
        <li>Return a new builder. The builder will be defaulted with a 
   {@link JsonInstanceSerializer}
   <p>.<br/>
   @@ -39,7 +40,7 @@ public class ServiceDiscoveryBuilder<T><br/>
         */<br/>
        public static<T> ServiceDiscoveryBuilder<T>     builder(Class<T> 
payloadClass)</p>
        {
   -return new ServiceDiscoveryBuilder<T>(payloadClass).serializer(new 
JsonInstanceSerializer<T>(payloadClass));
   +return new ServiceDiscoveryBuilder<T>(payloadClass);
        }</li>
   </ul>
   
   
   <p>     /**<br/>
   @@ -49,6 +50,11 @@ public class ServiceDiscoveryBuilder<T><br/>
         */<br/>
        public ServiceDiscovery<T>      build()<br/>
        {<br/>
   +<br/>
   +if (serializer == null) </p>
   {
   +    serializer = new JsonInstanceSerializer<T>(payloadClass);
   +}
   <p>+<br/>
    return new ServiceDiscoveryImpl<T>(client, basePath, serializer, 
thisInstance);<br/>
        }</p>
   
   <p>@@ -102,5 +108,6 @@ public class ServiceDiscoveryBuilder<T></p>
   
   <p>     ServiceDiscoveryBuilder(Class<T> payloadClass)</p>
        {
   +this.payloadClass = payloadClass;
        }
   <p> }</p>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org