Re: [I] [CURATOR-67] Issue with default JSONInstanceSerializer for discovery service builder [curator]

[via GitHub]

jira-importer commented on issue #588:
URL: https://github.com/apache/curator/issues/588#issuecomment-2604700899

   <i><a 
href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=githubbot";>githubbot</a>:</i>
   <p>Github user madrob commented on a diff in the pull request:</p>
   
   <p>    <a 
href="https://github.com/apache/curator/pull/30#discussion_r15755406"; 
class="external-link" target="_blank" rel="nofollow 
noopener">https://github.com/apache/curator/pull/30#discussion_r15755406</a></p>
   
   <p>    &#8212; Diff: 
curator-x-discovery/src/test/java/org/apache/curator/x/discovery/details/TestServiceDiscoveryBuilder.java
 &#8212;<br/>
       @@ -0,0 +1,68 @@<br/>
       +/**<br/>
       + * Licensed to the Apache Software Foundation (ASF) under one<br/>
       + * or more contributor license agreements.  See the NOTICE file<br/>
       + * distributed with this work for additional information<br/>
       + * regarding copyright ownership.  The ASF licenses this file<br/>
       + * to you under the Apache License, Version 2.0 (the<br/>
       + * "License"); you may not use this file except in compliance<br/>
       + * with the License.  You may obtain a copy of the License at<br/>
       + *<br/>
       + *   <a href="http://www.apache.org/licenses/LICENSE-2.0"; 
class="external-link" target="_blank" rel="nofollow 
noopener">http://www.apache.org/licenses/LICENSE-2.0</a><br/>
       + *<br/>
       + * Unless required by applicable law or agreed to in writing,<br/>
       + * software distributed under the License is distributed on an<br/>
       + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY<br/>
       + * KIND, either express or implied.  See the License for the<br/>
       + * specific language governing permissions and limitations<br/>
       + * under the License.<br/>
       + */<br/>
       +package org.apache.curator.x.discovery.details;<br/>
       &#8212; End diff &#8211;</p>
   
   <p>    I put the test in o.a.c.x.discovery.details so that I could use the 
package level access methods on ServiceDiscoveryImpl to verify the serializer 
class. If I move the package up, then I guess I can still get at it using 
reflection, or by increasing the visibility of 
ServiceDiscoveryImpl.getSerializer(). Your call.</p>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@curator.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org