Should be all fixed now. I had to rely on a snapshot of buildtools as I
needed to update the checkstyle rules a bit, but I'll release that with 2.3.1
hopefully later today if I'm nothing else major pops up and I can somehow get
out of meeting hell.
Dan
On Wednesday 01 December 2010 11:50:54 am Daniel Kulp wrote:
> On Wednesday 01 December 2010 6:01:14 am Dennis Sosnoski wrote:
> > Tried this, even going with the default workspace this time, rather than
> > the one I'd specified before. Still the same results, though.
> >
> > I did have two Checkstyle sheets in the project properties, so I went
> > into my Eclipse configuration and saw that there appeared to be two
> > versions of the plugin installed. I uninstalled the older one, leaving
> > only the "Eclipse Checkstyle Plug-in" version 5.2.0.201010072021 After
> > restarting Eclipse there's just one Checkstyle sheet, and that's using
> > the "CXF Checks - (Global)" configuration. I'm running Eclipse version
> > 3.6.1, M20100909-0800.
>
> Definitely a Checkstyle version thing. I was using 5.1.0.something and
> everything was working fine. I just updated to 5.2.0 and now I'm seeing
> the same errors. Thanks for breaking my eclipse setup.... ;-)
>
> I'll see if I can get it fixed and committed.
>
> Dan
>
> > It looks like both the "Got an exception - unexpected char: 0xFFFF" and
> > the "Missing a header - not enough lines in file." errors can be fixed
> > by adding a newline at the end of the file. You don't got those errors
> > on files which don't end with a newline? (such as
> > cxf-systests-jaxws/src/test/java/org/apache/cxf/systest/handlers/AddNumbe
> > rs Unwrap.java). If not, and assuming I'm not the only person running
> > Linux, could it be a Checkstyle version issue?
> >
> > The "Wrong order for ... import" errors sometimes appear to be related
> > to the use of static imports, where the static imports are in a block
> > following the regular imports, and in other cases involve jUnit imports
> > - it looks like Checkstyle expects these to follow the
> > org.springframework imports.
> >
> > - Dennis
> >
> > On 11/30/2010 06:03 AM, Daniel Kulp wrote:
> > > On Friday 26 November 2010 6:47:11 pm Dennis Sosnoski wrote:
> > >> My original message is included in this one, at the bottom. There are
> > >> three different variations of Checkstyle errors: 1) unexpected char:
> > >> 0xFFFF; 2) Missing a header - not enough lines in file; and 3) Wrong
> > >> order for import.
> > >
> > > Occasionally, when importing the projects, Eclipse gets confused and
> > > doesn't get everything setup correctly. Steps to resolve:
> > >
> > > 1) From the command line, re-run "mvn -Psetup.eclipse" to make sure
> > > everything is regenerated properly.
> > >
> > > 2) Select all the projects in eclipse and do File -> Refresh to reload
> > > them
> > >
> > > 3) Select all the projects and do a Project -> Clean to force eclipse
> > > to rebuild them.
> > >
> > > If that DOESN'T help, then right click on one of the projects and
> > > bring up the properties for it. On the "Checkstyle" page, make sure
> > > it says it's using the "CXF Checks - (Global)" configuration. If
> > > it's not, that's the issue. The -Psetup.eclipse profile should be
> > > injecting the CXF Checks configuration into your workspace (which, by
> > > default, is ../workspace from the cxf directory). If that didn't
> > > work, you may need to add
> > > -Declipse.workspace.dir=/path/to/workspace to the command line to make
> > > sure it gets added.
> > >
> > > The BEST option which definitely helps with the maven eclipse plugin is
> > > to
> > >
> > > edit your ~/.m2/setttings.xml and add a profile like:
> > > <activeProfiles>
> > >
> > > <activeProfile>extra</activeProfile>
> > >
> > > </activeProfiles>
> > > <profiles>
> > >
> > > <profile>
> > >
> > > <id>extra</id>
> > > <properties>
> > >
> > > <eclipse.workspace>/home/dkulp/working/workspace</eclip
> > > se .workspace> <downloadSources>true</downloadSources>
> > > <eclipse.workspace.dir>/home/dkulp/working/workspace</
> > > ecl ipse.workspace.dir>
> > > <eclipse.output.directory>${project.build.outputDirecto
> > > r y}</eclipse.output.directory>
> > >
> > > </properties>
> > >
> > > </profile>
> > >
> > > </profiles>
> > >
> > > or similar which pretty much makes sure everything always points to the
> > > right workspace and sources are always downloaded and such. Pretty
> > > much would help with ANY maven project where you may use the
> > > maven-eclipse-plugin.
> > >
> > >
> > > Dan
> > >
> > >> - Dennis
> > >>
> > >> On 11/27/2010 11:04 AM, Benson Margulies wrote:
> > >>> Sigh. I deleted your original message. What do the errors look like?
> > >>>
> > >>> On Fri, Nov 26, 2010 at 4:07 PM, Dennis Sosnoski <d...@sosnoski.com>
>
> wrote:
> > >>>> Had the subversion plugin, but was missing subversion itself on the
> > >>>> system I was using. :-) Installed that, installed the matching
> > >>>> version of subclipse, deleted and re-imported the projects, and now
> > >>>> I'm left with "just" the errors.
> > >>>>
> > >>>> Thanks,
> > >>>>
> > >>>> - Dennis
> > >>>>
> > >>>> On 11/27/2010 02:53 AM, Benson Margulies wrote:
> > >>>>> Looks like you lack a subversion plugin to eclipse, which would
> > >>>>> somehow prevent the cs plugin from descending into your .svn
> > >>>>> directories.
> > >>>>>
> > >>>>> On Fri, Nov 26, 2010 at 5:10 AM, Dennis Sosnoski <d...@sosnoski.com>
> > >
> > > wrote:
> > >>>>>> I've followed the instructions at
> > >>>>>> http://cxf.apache.org/setting-up-eclipse.html to create an Eclipse
> > >>>>>> project using the current trunk code, but Eclipse gives me a bunch
> > >>>>>> of Checkstyle errors as well as a bunch of warnings. Here's a
> > >>>>>> representative sampling of the Checkstyle errors (89 in all):
> > >>>>>>
> > >>>>>> Got an exception - unexpected char: 0xFFFF AddNumbers.java
> > >>>>>> /cxf-systests-jaxws/src/test/java/org/apache/cxf/systest/handlers/
> > >>>>>> ty pe s line 93 Checkstyle Problem
> > >>>>>> Missing a header - not enough lines in file. package-info.java
> > >>>>>> /cxf-systests-jaxws/src/test/java/org/apache/cxf/systest/handlers/
> > >>>>>> ty pe s line 1 Checkstyle Problem
> > >>>>>> Wrong order for
> > >>>>>> 'org.apache.cxf.binding.soap.Soap11.SOAP_NAMESPACE' import.
> > >>>>>> MAPAggregatorTest.java
> > >>>>>> /cxf-rt-ws-addr/src/test/java/org/apache/cxf/ws/addressing line
> > >>>>>> 69 Checkstyle Problem
> > >>>>>>
> > >>>>>> The warnings (346) all appear to relate to svn files included in
> > >>>>>> the src tree:
> > >>>>>>
> > >>>>>> The resource is a duplicate of src/main/java/.svn/all-wcprops and
> > >>>>>> was not copied to the output folder all-wcprops
> > >>>>>> /cxf-systests-java2ws/src/main/resources/.svn Unknown Java
> > >>>>>> Problem The resource is a duplicate of
> > >>>>>> src/main/java/.svn/all-wcprops and was not copied to the output
> > >>>>>> folder all-wcprops
> > >>>>>> /cxf-xerces-xsd-validation/src/main/resources/.svn Unknown
> > >>>>>> Java Problem
> > >>>>>> The resource is a duplicate of src/main/java/.svn/entries and was
> > >>>>>> not copied to the output folder entries
> > >>>>>> /cxf-systests-java2ws/src/main/resources/.svn Unknown Java
> > >>>>>> Problem The resource is a duplicate of src/main/java/.svn/entries
> > >>>>>> and was not copied to the output folder entries
> > >>>>>> /cxf-xerces-xsd-validation/src/main/resources/.svn Unknown
> > >>>>>> Java Problem
> > >>>>>>
> > >>>>>> Are these all expected problems, or do I have something
> > >>>>>> misconfigured?
> > >>>>>>
> > >>>>>> Thanks,
> > >>>>>>
> > >>>>>> - Dennis
> > >>>>>>
> > >>>>>> --
> > >>>>>>
> > >>>>>> Dennis M. Sosnoski
> > >>>>>> Java SOA and Web Services Consulting
> > >>>>>> <http://www.sosnoski.com/consult.html> Axis2/CXF/Metro SOA and Web
> > >>>>>> Services Training
> > >>>>>> <http://www.sosnoski.com/training.html>
> > >>>>>> Web Services Jump-Start <http://www.sosnoski.com/jumpstart.html>
--
Daniel Kulp
dk...@apache.org
http://dankulp.com/blog
