Removing Nabble links... On Wed, Mar 9, 2011 at 10:40 AM, Sergey Beryozkin <sberyoz...@gmail.com>wrote:
> Hi Andy > > On Tue, Mar 8, 2011 at 9:58 PM, Andrzej Michalec < > andrzej.micha...@gmail.com> wrote: > >> > sorry, I'm not following :-) We have PrimitiveSearchCondition which >> wraps >> an >> > expression like "a==2". >> > [...] >> >> I spent an hour trying to recreate that problem and actually I confused >> myself because I am not able to do so :) When I started working on search >> condition builder I did a little play with FiqlParser and >> SimpleSearchCondition and found problems I described. I was sure I did >> update to head revision. Anyway, then I trashed these files as irrelevant >> to >> our fluent interface case, but I remembered in back of my head troubles I >> reached and tested. Now I have neither idea nor time to figure that out >> especially that it is really working! I think it is your refactoring to >> PrimitiveSearchCondition that get rid of problem I faced. Well... feeling >> shamed a bit I am happy at the same time that the code is really stable. >> >> > Not a problem at all and the really good thing is that you've looked again > through the code you wrote awhile back and thus enhancing it can be a walk > in the park for you in the future :-). Thanks for taking care of this issue > - you may've spotted something after all and if yes then the issue will be > back on the agenda soon :-) > > >> I am going to revert these changes in minutes and then tune up >> SearchConditionBuilder as we agreed. >> >> cool, thanks > > Sergey > > >> cheers, >> -andy. >> >>
