reta commented on code in PR #3521: URL: https://github.com/apache/cxf/pull/3521#discussion_r4179684946
########## rt/features/logging/src/main/java/org/apache/cxf/ext/logging/LoggingOutInterceptor.java: ########## Review Comment: > But at this point It's very possible it was only due to [CXF-9110](https://issues.apache.org/jira/browse/CXF-9110) 4.0.6 ... The Cos were close (first log), but failed to deregister due to second line missing (that U add in 4.0.7): 👍 thank you > In my case the log (first one) is done when DelayedCachedOutputStreamCleaner clean... and the payload is still available (write() at a certain point fail as we know ... but in cos the same byte wrote to the socket are copied safely). I prototyped one option there https://github.com/apache/cxf/pull/3536 to capture failed writes and **do not log** anything: in this case we do not send any response since it was never written but the exception will appear in logs (as it should). > Also ,now that I think about it, that DelayedCachedOutputStreamCleaner close only the cos that have a tmp file. So the one with no tmp file (default 48KB ...so all ) are never never close ...and so also those log are surely missing. Temp files fill up the disk, inmem are garbage collected for free -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
