Github user stevedlawrence commented on a diff in the pull request:

    https://github.com/apache/incubator-daffodil/pull/5#discussion_r150862972
  
    --- Diff: 
daffodil-core/src/main/scala/edu/illinois/ncsa/daffodil/dsom/SchemaComponentFactory.scala
 ---
    @@ -33,29 +33,40 @@
     package edu.illinois.ncsa.daffodil.dsom
     
     import edu.illinois.ncsa.daffodil.exceptions.SchemaFileLocatable
    -import edu.illinois.ncsa.daffodil.xml.GetAttributesMixin
     import edu.illinois.ncsa.daffodil.xml.XMLUtils
     import edu.illinois.ncsa.daffodil.exceptions.ThrowsSDE
     import scala.xml.NamespaceBinding
     import edu.illinois.ncsa.daffodil.xml.NS
     import edu.illinois.ncsa.daffodil.oolag.OOLAG.OOLAGHost
    +import scala.xml.Node
     
     /**
      * Anything that can be computed without reference to the point of use
      * or point of reference can be computed here on these factory objects.
      */
    -class SchemaComponentFactory(override val xml: scala.xml.Node,
    -  override val schemaDocument: SchemaDocument)
    -  extends OOLAGHost(schemaDocument)
    -  with SchemaFileLocatableImpl
    -  with CommonContextMixin
    -  with GetAttributesMixin
    -  with ImplementsThrowsSDE
    +abstract class SchemaComponentFactory( final override val xml: Node,
    +  final override val schemaDocument: SchemaDocument)
    +  extends SchemaComponent
       with NestingLexicalMixin {
    +  //  extends OOLAGHost(schemaDocument)
    +  //  with SchemaFileLocatableImpl
    +  //  with CommonContextMixin
    +  //  with GetAttributesMixin
    +  //  with ImplementsThrowsSDE
    +  //  with NestingLexicalMixin {
    +
    --- End diff --
    
    Remove comments


---

Reply via email to