Github user stevedlawrence commented on a diff in the pull request:
https://github.com/apache/incubator-daffodil/pull/5#discussion_r150869739
--- Diff:
daffodil-lib/src/main/scala/edu/illinois/ncsa/daffodil/schema/annotation/props/PropertyScoping.scala
---
@@ -209,8 +209,10 @@ trait FindPropertyMixin extends PropTypes {
* For unit testing convenience
*/
final def verifyPropValue(key: String, value: String): Boolean = {
- findPropertyOption(key) match {
- case Found(`value`, _, _, _) => true
+ val prop = findPropertyOption(key)
+ val valueLC = value.toLowerCase
+ prop match {
+ case Found(v, _, _, _) if (v.toLowerCase == valueLC) => true
--- End diff --
I was about to make a comment about using String.equalsIgnoreCase since
that might be a little faster in some cases. But then realized this is only
used in unit tests. Should this just be moved to a unit test file? Also seems
that we would want to be strict about checking case during unit tests? Case
matters with property values, right?
---
