stevedlawrence commented on a change in pull request #16: Implemented packed
binary formats
URL: https://github.com/apache/incubator-daffodil/pull/16#discussion_r155255945
##########
File path:
daffodil-core/src/main/scala/edu/illinois/ncsa/daffodil/grammar/ElementBaseGrammarMixin.scala
##########
@@ -480,7 +504,8 @@ trait ElementBaseGrammarMixin
case LengthKind.Implicit => implicitBinaryLengthInBits
case LengthKind.Explicit if (lengthEv.isConstant) =>
explicitBinaryLengthInBits()
case LengthKind.Explicit => -1 // means must be computed at runtime.
- case LengthKind.Delimited => subsetError("lengthKind='delimited' not yet
supported.")
+ case LengthKind.Delimited if (binaryNumberRep == BinaryNumberRep.Binary)
=> subsetError("lengthKind='delimited' only supported for packed binary
formats.")
+ case LengthKind.Delimited => -1
Review comment:
Might be useful to add a comment here clarifying that this is only for the
packed/zoned stuff, and length must be computed at runtime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
