stevedlawrence commented on a change in pull request #16: Implemented packed
binary formats
URL: https://github.com/apache/incubator-daffodil/pull/16#discussion_r155260038
##########
File path:
daffodil-core/src/main/scala/edu/illinois/ncsa/daffodil/grammar/primitives/PrimitivesBCD.scala
##########
@@ -32,7 +32,42 @@
package edu.illinois.ncsa.daffodil.grammar.primitives
-import edu.illinois.ncsa.daffodil.dsom._
+import edu.illinois.ncsa.daffodil.grammar.Terminal
import edu.illinois.ncsa.daffodil.dsom.ElementBase
+import
edu.illinois.ncsa.daffodil.processors.parsers.BCDIntegerRuntimeLengthParser
+import
edu.illinois.ncsa.daffodil.processors.parsers.BCDIntegerKnownLengthParser
+import
edu.illinois.ncsa.daffodil.processors.parsers.BCDDecimalRuntimeLengthParser
+import
edu.illinois.ncsa.daffodil.processors.parsers.BCDDecimalKnownLengthParser
+import edu.illinois.ncsa.daffodil.processors.unparsers.Unparser
+import
edu.illinois.ncsa.daffodil.processors.unparsers.BCDIntegerRuntimeLengthUnparser
+import
edu.illinois.ncsa.daffodil.processors.unparsers.BCDIntegerKnownLengthUnparser
+import
edu.illinois.ncsa.daffodil.processors.unparsers.BCDDecimalRuntimeLengthUnparser
+import
edu.illinois.ncsa.daffodil.processors.unparsers.BCDDecimalKnownLengthUnparser
-case class BCDIntPrim(e: ElementBase) extends UnimplementedPrimitive(e, false)
+class BCDIntegerRuntimeLength(val e: ElementBase) extends Terminal(e, true) {
+ override lazy val parser = new
BCDIntegerRuntimeLengthParser(e.elementRuntimeData, e.lengthEv, e.lengthUnits)
+
+ override lazy val unparser: Unparser = new
BCDIntegerRuntimeLengthUnparser(e.elementRuntimeData, e.lengthEv, e.lengthUnits)
+}
+
+class BCDIntegerKnownLength(val e: ElementBase, lengthInBits: Long) extends
Terminal(e, true) {
+
+ override lazy val parser = {
+ new BCDIntegerKnownLengthParser(e.elementRuntimeData, lengthInBits.toInt)
+ }
Review comment:
Curly braces aren't really needed--removing makes them more consistent with
the surrounding code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
