jadams-tresys commented on a change in pull request #16: Implemented packed
binary formats
URL: https://github.com/apache/incubator-daffodil/pull/16#discussion_r155280210
##########
File path:
daffodil-core/src/main/scala/edu/illinois/ncsa/daffodil/grammar/ElementBaseGrammarMixin.scala
##########
@@ -301,7 +319,13 @@ trait ElementBaseGrammarMixin
case Float => true
case Double => true;
case n: Numeric.Kind =>
- binaryNumberRep eq BinaryNumberRep.Binary
+ binaryNumberRep match {
+ case BinaryNumberRep.Binary => true
+ case BinaryNumberRep.Packed => false
+ case BinaryNumberRep.Bcd => false
+ case BinaryNumberRep.Ibm4690Packed => false
+ case _ => false
+ }
Review comment:
Will fix, this was simply left over as I was implementing the different
packed formats one at a time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
