jadams-tresys commented on a change in pull request #16: Implemented packed binary formats URL: https://github.com/apache/incubator-daffodil/pull/16#discussion_r162074543
########## File path: daffodil-runtime1-unparser/src/main/scala/edu/illinois/ncsa/daffodil/processors/unparsers/PackedBinaryUnparserTraits.scala ########## @@ -0,0 +1,70 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package edu.illinois.ncsa.daffodil.processors.unparsers + +import edu.illinois.ncsa.daffodil.processors.ElementRuntimeData +import edu.illinois.ncsa.daffodil.processors.ParseOrUnparseState +import edu.illinois.ncsa.daffodil.util.Maybe._ +import java.lang.{ Number => JNumber } +import java.math.{ BigDecimal => JBigDecimal } +import edu.illinois.ncsa.daffodil.exceptions.Assert +import edu.illinois.ncsa.daffodil.io.DataOutputStream +import edu.illinois.ncsa.daffodil.io.FormatInfo +import edu.illinois.ncsa.daffodil.schema.annotation.props.gen.BinaryNumberCheckPolicy + +trait PackedBinaryConversion { + def fromBigInteger(num: String, nBits: Int, signCodes: String, policy: BinaryNumberCheckPolicy): Array[Byte] +} + +abstract class PackedBinaryBaseUnparser( + e: ElementRuntimeData, + binaryPackedSignCodes: String = "", Review comment: So this may just be my ignorance of Scala, but I was trying to provide a generic base class that could be used by Packed, BCD, and IBM4690. The binaryPackedSignCodes and binaryNumberCheckPolicy properties are only used by PackedDecimal, so I thought the best way to make this generic interface work would be to have default values which are simply ignored by BCD and IBM4690. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
