stevedlawrence commented on a change in pull request #12: Revised daffodil-io
module to require passing in a FormatInfo object.
URL: https://github.com/apache/incubator-daffodil/pull/12#discussion_r158030702
##########
File path:
daffodil-io/src/main/scala/edu/illinois/ncsa/daffodil/io/DataStreamCommonImplMixin.scala
##########
@@ -57,25 +72,21 @@ trait DataStreamCommonState {
// aka a surrogate-pair.
//
var maybeTrailingSurrogateForUTF8: MaybeChar = MaybeChar.Nope
- // var priorEncoding: Charset = StandardCharsets.UTF_8
var priorBitPos: Long = 0L
def resetUTF8SurrogatePairCapture {
- // this.maybeTrailingSurrogateForUTF8 = MaybeChar.Nope
this.priorBitPos = -1
}
def assignFrom(other: DataStreamCommonState): Unit = {
- // this.binaryFloatRep = other.binaryFloatRep
- // this.bitOrder = other.bitOrder
- // this.maybeCharWidthInBits = other.maybeCharWidthInBits
- // this.encodingMandatoryAlignmentInBits =
other.encodingMandatoryAlignmentInBits
- // this.maybeUTF16Width = other.maybeUTF16Width
this.debugging = other.debugging
this.limits_ = other.limits_
- // this.maybeTrailingSurrogateForUTF8 =
other.maybeTrailingSurrogateForUTF8
- // this.priorEncoding = other.priorEncoding
this.priorBitPos = other.priorBitPos
+ if (this.maybePriorBitOrder_.isDefined &&
+ other.maybePriorBitOrder_.isDefined &&
+ (this.maybePriorBitOrder_.get ne other.maybePriorBitOrder_.get)) {
+ }
Review comment:
Empty if-condition? Looks like this was thinking about checking for bitOrder
changes on a non-byte boundary? But doesn't have the boundary check and doesn't
error? Maybe that happens somewhere else? Not sure it needs to be done here and
this can be removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
