stevedlawrence commented on a change in pull request #12: Revised daffodil-io
module to require passing in a FormatInfo object.
URL: https://github.com/apache/incubator-daffodil/pull/12#discussion_r158044717
##########
File path:
daffodil-runtime1/src/main/scala/edu/illinois/ncsa/daffodil/processors/parsers/ElementKindParsers.scala
##########
@@ -49,7 +50,7 @@ class ComplexTypeParser(rd: RuntimeData, bodyParser: Parser)
def parse(start: PState): Unit = {
start.mpstate.childIndexStack.push(1L) // one-based indexing
- bodyParser.parse1(start)
+ start.parse1(bodyParser)
Review comment:
Agreed. I think what you have before is correct. And agreed on the parse1/2
naming (or combining if possible). Something better would be helpful to make it
more clear when they should be called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
