mbeckerle commented on a change in pull request #70: Adding property
binaryCalendarRep with values "binarySeconds" and "bi…
URL: https://github.com/apache/incubator-daffodil/pull/70#discussion_r189964002
##########
File path:
daffodil-test/src/test/resources/org/apache/daffodil/section05/simple_types/SimpleTypes.tdml
##########
@@ -1951,6 +1966,87 @@
</tdml:infoset>
</tdml:parserTestCase>
+ <!-- xs:dateTime with binaryCalendarRep='binarySeconds' -->
+ <tdml:parserTestCase name="dateTimeBin" root="dateTimeBin"
+ model="SimpleTypes-binary" description="Section 5 Schema types-dateTime -
DFDL-5-016R"
+ roundTrip="true">
+
+ <tdml:document>
+ <tdml:documentPart type="bits">00000000 00000000 00000000
00111110</tdml:documentPart>
+ </tdml:document>
+ <tdml:infoset>
+ <tdml:dfdlInfoset>
+ <dateTimeBin>1977-01-01T00:01:09.000000+00:00</dateTimeBin>
+ </tdml:dfdlInfoset>
+ </tdml:infoset>
+ </tdml:parserTestCase>
+
+ <tdml:parserTestCase name="dateTimeBin2" root="dateTimeBin2"
+ model="SimpleTypes-binary" description="Section 5 Schema types-dateTime -
DFDL-5-016R"
+ roundTrip="false">
+
+ <tdml:document>
+ <tdml:documentPart type="bits">00000000 00000000 00000000
00111101</tdml:documentPart>
+ </tdml:document>
+ <tdml:errors>
+ <tdml:error>Schema Definition Error: lengthUnits must be 'bytes' when
binaryCalendarRep='binarySeconds'</tdml:error>
+ </tdml:errors>
+ </tdml:parserTestCase>
+
+ <tdml:parserTestCase name="dateTimeBin3" root="dateTimeBin3"
+ model="SimpleTypes-binary" description="Section 5 Schema types-dateTime -
DFDL-5-016R"
+ roundTrip="false">
+
+ <tdml:document>
+ <tdml:documentPart type="bits">00000000 00000000 00000000
00111101</tdml:documentPart>
+ </tdml:document>
+ <tdml:errors>
+ <tdml:error>Schema Definition Error: binary xs:dateTime must be 32 bits
when binaryCalendarRep='binarySeconds'</tdml:error>
+ </tdml:errors>
+ </tdml:parserTestCase>
+
+ <!-- xs:dateTime with binaryCalendarRep='binarySeconds' with implicit length
-->
+ <tdml:parserTestCase name="dateTimeBin4" root="dateTimeBin4"
+ model="SimpleTypes-binary" description="Section 5 Schema types-dateTime -
DFDL-5-016R"
+ roundTrip="true">
+
+ <tdml:document>
+ <tdml:documentPart type="bits">11111111 11111110 10101110
10000000</tdml:documentPart>
+ </tdml:document>
+ <tdml:infoset>
+ <tdml:dfdlInfoset>
+ <dateTimeBin4>1869-12-31T00:05:00.000000+00:00</dateTimeBin4>
+ </tdml:dfdlInfoset>
+ </tdml:infoset>
+ </tdml:parserTestCase>
+
+ <!-- xs:dateTime with binaryCalendarRep='binaryMillieconds' -->
+ <tdml:parserTestCase name="dateTimeBin5" root="dateTimeBin5"
Review comment:
I'm curious now as to what date/time 64-bits of all 1's as
binaryMilliseconds is. I wonder if it can be represented with 4-digits for
year. Probably not. I don't know if the Java date/time libraries will work for
this. It would be good to have tests that characterize the range that Java's
date/time stuff supports. I.e., what is the max 64-bit integer for binary
milliseconds that they are able to support, and what kinds of errors occur when
the limits are exceeded.
Another interesting dateTime would be 9999-12-31T23-59-59.999999Z which is
the last millisecond of the "4-digit year" era. We should certainly have tests
that have that, and the next millisecond after it, which would be
10000-01-01T00-00-00.000000Z.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
