stevedlawrence commented on a change in pull request #100: Moved
pushDiscriminator to fix separators bug.
URL: https://github.com/apache/incubator-daffodil/pull/100#discussion_r210238731
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SeparatedSequenceParsers.scala
##########
@@ -299,6 +299,18 @@ final class OrderedSeparatedSequenceParser(
val bitPosBeforeSeparator = pstate.bitPos0b
+ pstate.pushDiscriminator
Review comment:
Ah, I now see how the discriminator can apply with postfix separators. Looks
good to me. I'm okay with moving push/pop to the base class too.
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
