stevedlawrence commented on a change in pull request #100: Moved
pushDiscriminator to fix separators bug.
URL: https://github.com/apache/incubator-daffodil/pull/100#discussion_r210258761
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SequenceParserBases.scala
##########
@@ -155,8 +148,7 @@ abstract class OrderedSequenceParserBase(
//
val priorState =
if (isFirstIteration) {
- beforeArrayState = pstate.mark("before all occurrences")
- beforeArrayState
+ pstate.mark("before all occurrences")
} else {
pstate.mark("before second/subsequent occurrence")
}
Review comment:
The isFirstIteration block is now the same as the else block. Worth it to
just make ``priorState = pstate.mark(...)``?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
