mbeckerle commented on a change in pull request #152: Daffodil 2028 cross test
URL: https://github.com/apache/incubator-daffodil/pull/152#discussion_r241087563
##########
File path:
daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/RunnerFactory.scala
##########
@@ -67,7 +67,20 @@ object Runner {
* A test or test suite can override this to specify more or different
implementations
* that the test should pass for.
*/
- def defaultImplementationsDefaultDefault = Seq("daffodil")
+ def defaultImplementationsDefaultDefault = Seq("daffodil", "ibm")
+
+ /**
+ * By default we don't run Daffodil negative TDML tests against
cross-testers.
+ * The error messages are simply too varied.
+ *
+ * Negative tests must fail, but error messages aren't compared.
+ */
+ def defaultShouldCrossTestNegativeTests = false
+
+ /**
+ * By default we don't cross test warning messages because they are too
varied.
+ */
+ def defaultShouldCrossTestWarnings = false
Review comment:
rename? shouldCrossTestCompareWarnings
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
