mbeckerle commented on a change in pull request #152: Daffodil 2028 cross test
URL: https://github.com/apache/incubator-daffodil/pull/152#discussion_r241086702
 
 

 ##########
 File path: 
daffodil-lib/src/main/resources/edu/illinois/ncsa/daffodil/xsd/built-in-formats.xsd
 ##########
 @@ -61,7 +61,7 @@
                                gets you only the new properties without all 
the property settings of daffodilTest1. -->
 
                        <dfdl:defineFormat name="daffodilNewProperties1">
-                               <dfdl:format encodingErrorPolicy="replace" 
sequenceKind="ordered"
+                               <dfdl:format encodingErrorPolicy="error" 
sequenceKind="ordered"
 
 Review comment:
   Revert. We don't use this format. It was kept in for backward compat 
reasons. So we shouldn't be changing it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to