stevedlawrence commented on a change in pull request #207: Added support for
enumerations and TypeValueCalc
URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278611774
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/SimpleTypes.scala
##########
@@ -194,7 +280,10 @@ abstract class SimpleTypeDefBase(xml: Node, parent:
SchemaComponent)
optRestriction.flatMap { r => toOpt(r.hasTotalDigits,
r.totalDigitsValue) },
optRestriction.flatMap { r => toOpt(r.hasFractionDigits,
r.fractionDigitsValue) },
optUnion.orElse(optRestriction.flatMap { _.optUnion }).toSeq.flatMap {
_.unionMemberTypes.map { _.simpleTypeRuntimeData } },
- tunable)
+ tunable,
+ optRepTypeDef.map(_.simpleTypeRuntimeData),
+ optRepValueSet,
+ factory.optTypeCalculator)
Review comment:
Are we sure we need to add the value set and type calculator to the
SimpleTypeRuntimeData? If feels like we should be able to fully calculate that
information at schema compile time and pass those to the parsers that needed
it. Keeping RuntimeData small when possible should help our memory usage. I
feel like there's already a bunch of unnecessary stuff in this object, would be
nice tominimize adding new things if not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
