stevedlawrence commented on a change in pull request #207: Added support for 
enumerations and TypeValueCalc
URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279826798
 
 

 ##########
 File path: 
daffodil-core/src/main/scala/org/apache/daffodil/dsom/CompiledExpression.scala
 ##########
 @@ -55,7 +55,8 @@ class ExpressionCompiler[T <: AnyRef] extends 
ExpressionCompilerBase[T] {
     namespaces: NamespaceBinding,
     compileInfoWherePropertyWasLocated: DPathCompileInfo,
     isEvaluatedAbove: Boolean,
-    host: OOLAGHost): CompiledExpression[T] = {
+    host: OOLAGHost,
+    compileInfo: DPathCompileInfo): CompiledExpression[T] = {
 
 Review comment:
   We should probably change the name then, or at least add some documentation 
clarifiing the difference. compileInfoWherePropertyWasLocated and 
compiledInfoWherePropertyWasExpressed?
   
   So in your example, compileInfoWherePropertyWasLocated would contain an 
actual element, but compileInfoWherePropertyWasExpressed might be on the 
dfdl:format tag or something?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to