mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285259505
########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala ########## @@ -94,8 +94,7 @@ trait ChoiceDefMixin } } -abstract class ChoiceTermBase( - final override val xml: Node, +abstract class ChoiceTermBase(final override val xml: Node, Review comment: I didn't find anything in the scala style site about method argument declarations. They're clear about Constructor arg declarations, and I don't see why method argument declarations wouldn't follow the same rule. But the style site doesn't say, and Scalariform doesn't do it that way by default. Personally, I think args should all go on one line unless the line is too long in which case they should go like Constructor args. I am not sure any of the automated tools would do this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
