mbeckerle commented on a change in pull request #214: Sequences and Separators 
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285661559
 
 

 ##########
 File path: 
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala
 ##########
 @@ -431,7 +431,7 @@ trait ElementBase
     if (isDefaultable && (isScalar || 
isArraywithAtLeastOneRequiredArrayElement)) {
       val dv =
         if (isNillable && useNilForDefault =:= YesNo.Yes) {
-          UseNilForDefault // singleton object indicator
+          Some(UseNilForDefault) // singleton object indicator
 
 Review comment:
   Doc  added. This is effectively the same AnyRef we see as the data value for 
simple-type elements. The useNilForDefault is a hack, but a standard technique, 
for providing special cases. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to