mbeckerle commented on a change in pull request #218: Implement
dfdl:choiceLength='explicit'
URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r290495993
##########
File path:
daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/SpecifiedLengthUnparsers.scala
##########
@@ -428,3 +429,20 @@ class SpecifiedLengthPrefixedUnparser(
}
}
+
+class ChoiceLengthUnparser(
+ eUnparser: Unparser,
+ rd: TermRuntimeData)
+ extends CombinatorUnparser(rd)
+ with CaptureUnparsingValueLength {
+
+ override lazy val runtimeDependencies = Vector()
+ override lazy val childProcessors = Vector(eUnparser)
+
+ override def unparse(state: UState): Unit = {
+ val elem = state.currentInfosetNode.asInstanceOf[DIElement]
+ captureValueLengthStart(state, elem)
+ eUnparser.unparse1(state)
+ captureValueLengthEnd(state, elem)
+ }
Review comment:
One thing to keep in mind. The ChoiceLengthUnparser has slots in it that
capture state. That means these must be created on the fly as needed and are
not something that can be serialized as part of a saved parser/unparser,
because those are shared state that can be used by multiple threads
simultaneously. These ChoiceLengthUnparser instances must be per-thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
