mbeckerle commented on a change in pull request #218: Implement 
dfdl:choiceLength='explicit'
URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291430696
 
 

 ##########
 File path: 
daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/SpecifiedLength2.scala
 ##########
 @@ -476,34 +476,48 @@ class ElementUnusedUnparser(
  * simply a non-negative integer.
  */
 class ChoiceUnusedUnparserSuspendableOperation(
-  override val rd: ChoiceRuntimeData,
-  targetLengthInBits: Long,
-  maybeDOSStartForChoiceUnused: Maybe[DataOutputStream],
-  maybeDOSEndForChoiceUnused: Maybe[DataOutputStream])
+  override val rd: ModelGroupRuntimeData,
+  targetLengthInBits: Long)
   extends SuspendableOperation
   with StreamSplitter
   with SkipTheBits {
 
   private var zlStatus_ : ZeroLengthStatus = ZeroLengthStatus.Unknown
 
 Review comment:
   Here's the zero-length status use. This object is only created at runtime 
now, so yeah ZeroLengthStatus probably doesn't have to be serializable. That 
said. Doesn't hurt. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to