stevedlawrence commented on a change in pull request #228: Incremental progress
on Daffodil 1444 schema compiler space/speed issue.
URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r292030028
##########
File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Nesting.scala
##########
@@ -54,24 +61,61 @@ trait NestingMixin {
* schema components.
*/
trait NestingLexicalMixin
- extends NestingMixin {
+ extends NestingMixin { self: SchemaComponent =>
+ @deprecated("2019-06-03", "Use enclosingComponentDefs method, and deal with
sharing.")
override protected def enclosingComponentDef = optLexicalParent
+ final override protected lazy val enclosingComponentDefs:
Seq[(SchemaComponent, Int)] =
Review comment:
Thoughts on creating a new type instead of using a tuple here? Might make
things a bit more readable, something like
```scala
case class EnclosingComponentDef(lexicalParent: SchemaComponent,
lexicalPosition: Int)
```
Not sure if there's a benefit or not, but might help readablility,
especially once everything gets rewritten to using enclosingComponentDefs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
