stevedlawrence commented on a change in pull request #228: Incremental progress
on Daffodil 1444 schema compiler space/speed issue.
URL: https://github.com/apache/incubator-daffodil/pull/228#discussion_r292021428
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementDeclMixin.scala
##########
@@ -119,50 +149,83 @@ trait ElementDeclMixin
}
}.value
- final lazy val isSimpleType = LV('isSimpleType) {
- typeDef match {
- case _: SimpleTypeBase => true
- case _: ComplexTypeBase => false
- case _ => Assert.invariantFailed("Must be either SimpleType or
ComplexType")
- }
+}
+
+trait ElementDeclFactoryImplMixin
+ extends ElementDeclMixin {
+
+ final override lazy val optImmediateSimpleType: Option[SimpleTypeBase] =
LV('optImmediateSimpleType) {
+ val st = xml \ "simpleType"
+ val nt = typeName
Review comment:
nt not used? Is this just ensuring there's a typeName or can it be removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
