stevedlawrence commented on issue #228: Incremental progress on Daffodil 1444 
schema compiler space/speed issue.
URL: 
https://github.com/apache/incubator-daffodil/pull/228#issuecomment-500444559
 
 
   > A thought. This change introduces 41 deprecation errors. I had to switch 
off the checking that fails on warnings when compiling scala code.
   > 
   > Do we want a dev branch for this until those are resolved? (It will not be 
quick to resolve them all.)
   
   I don't think a separate dev branch is necessary at the momemt. As long as 
things aren't broken, I'd prefer to get changes in master as soon as possible 
to minimize issues dealing with merge conflicts in the future and get people 
used to the new stuff.
   
   I'd suggest either
   1. Turn off ``-Xfatal-warnings`` as you did
   2. Turn off ``-deprecation`` until the deprecated functions are removed. 
People trying to remove these deprecated functions can turn it back on during 
development to find the uses of deprecated functions.
   3. Just don't deprecate those functions at all and just work to eventually 
remove them. We can make sure during reviews that new code added doesn't use 
them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to