stevedlawrence commented on a change in pull request #233: Warn when DFDL
properties are ignored
URL: https://github.com/apache/incubator-daffodil/pull/233#discussion_r293921127
##########
File path:
daffodil-test/src/test/resources/org/apache/daffodil/section13/text_number_props/TextNumberProps.tdml
##########
@@ -3462,10 +3467,10 @@
<xs:element name="nanInvalid" dfdl:lengthKind="delimited"
dfdl:terminator="]" type="xsd:double"
dfdl:textStandardNaNRep="%#r" />
- <xs:element name="infInvalidType" dfdl:lengthKind="delimited"
type="xsd:long" dfdl:textStandardInfinityRep="INFINITY"
+ <xs:element name="infInvalidType" dfdl:lengthKind="delimited"
type="xsd:long"
dfdl:terminator="]" />
- <xs:element name="nanInvalidType" dfdl:lengthKind="delimited"
type="xsd:long" dfdl:textStandardNaNRep="NOTANUMBER"
+ <xs:element name="nanInvalidType" dfdl:lengthKind="delimited"
type="xsd:long"
Review comment:
This is a good point. Compared to how big our test base is, I was actually
surprised with how few unused properties there were. And the vast majority of
the these were testing that those properties were ignored. They were just
unnecessary properties (e.g. boolean props on a string type). So I dont' think
this changes things significantly.
In this particular case, this test was really just testing that
textStandardNanRep was ignored when the type was xs:long. I think that a
reasonable test, but I agree that it probably makes sense to add the property
back and expect a warning. I'll take a second pass and make sure there were any
tests that I fundamentally changed that should be checking for a warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
