stevedlawrence commented on a change in pull request #233: Warn when DFDL
properties are ignored
URL: https://github.com/apache/incubator-daffodil/pull/233#discussion_r294318549
##########
File path:
daffodil-test/src/test/resources/org/apache/daffodil/section13/text_number_props/TextNumberProps.tdml
##########
@@ -3462,10 +3467,10 @@
<xs:element name="nanInvalid" dfdl:lengthKind="delimited"
dfdl:terminator="]" type="xsd:double"
dfdl:textStandardNaNRep="%#r" />
- <xs:element name="infInvalidType" dfdl:lengthKind="delimited"
type="xsd:long" dfdl:textStandardInfinityRep="INFINITY"
+ <xs:element name="infInvalidType" dfdl:lengthKind="delimited"
type="xsd:long"
dfdl:terminator="]" />
- <xs:element name="nanInvalidType" dfdl:lengthKind="delimited"
type="xsd:long" dfdl:textStandardNaNRep="NOTANUMBER"
+ <xs:element name="nanInvalidType" dfdl:lengthKind="delimited"
type="xsd:long"
Review comment:
I've gone through the modified tests, and the i think there were only three
that were actually testing that a property was ignored. One I had already
noticed that tested that textNumberPattern was ignored for inputValueCalc. I
had already added a dfdl:warnign for that. THe other two were infInvalidType
and nanInvalidType, which tests that textStandardInfinityRep and
textStandardNaNRep are ignored for a non-float type.
The vast majority of the property removals were related to
dfdl:representation on xs:string and xs:hexBInary, or things like text
properties defined for a binary representation, which look like they were just
copy paste errors. So I think our tests are are still fine and are testing what
they say they are testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
