mbeckerle commented on a change in pull request #240: Add
dfdlx:choiceBranchKeyRanges
URL: https://github.com/apache/incubator-daffodil/pull/240#discussion_r295554199
##########
File path:
daffodil-test/src/test/resources/org/apache/daffodil/section15/choice_groups/choice.tdml
##########
@@ -1838,6 +1838,7 @@ it sure is/
<tdml:errors>
<tdml:error>Schema Definition Error</tdml:error>
<tdml:error>choiceBranchKey</tdml:error>
+ <tdml:error>choiceBranchKeyRanges</tdml:error>
<tdml:error>not defined</tdml:error>
</tdml:errors>
</tdml:parserTestCase>
Review comment:
I didn't see a test for the range list being odd length, though your code
does detect that and issue an SDE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
