mbeckerle commented on a change in pull request #240: Add dfdlx:choiceBranchKeyRanges URL: https://github.com/apache/incubator-daffodil/pull/240#discussion_r295552342
########## File path: daffodil-test/src/test/resources/org/apache/daffodil/extensions/choiceBranchRanges/choiceBranchKeyRanges.tdml ########## @@ -0,0 +1,204 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> + +<tdml:testSuite xmlns:ex="http://example.com"; xmlns="http://example.com"; + xmlns:tns="http://example.com"; + xmlns:tdml="http://www.ibm.com/xmlns/dfdl/testData"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xmlns:dfdl="http://www.ogf.org/dfdl/dfdl-1.0/"; xmlns:xs="http://www.w3.org/2001/XMLSchema"; + xmlns:dfdlx="http://www.ogf.org/dfdl/dfdl-1.0/extensions"; + xmlns:fn="http://www.w3.org/2005/xpath-functions"; + > + + <tdml:defineSchema name="choiceBranchKeyRanges-Embedded.dfdl.xsd"> Review comment: You don't have to follow this convention of naming the embedded schemas with these long names and "-Embedded.dfdl.xsd". That is something that got started long ago, but I think a shorter identifier without ".dfdl.xsd" and without repeating the name of the suite, or a class name on it is probably better given that people often copy/paste TDML and adapt to new purposes. One less name to have to change if you repurpose some TDML tests for a new purpose. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
