olabusayoT commented on a change in pull request #273: WIP: Add User Defined 
Functions Capability
URL: https://github.com/apache/incubator-daffodil/pull/273#discussion_r331206322
 
 

 ##########
 File path: 
daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/NodeInfo.scala
 ##########
 @@ -210,6 +210,25 @@ object NodeInfo extends Enum {
     }
   }
 
+  def fromClassTypeName(a: String) = {
+    a match {
+      // TODO figure out better solution
 
 Review comment:
   Indeed. I'd intended to implement the classOf way post our discussion but it 
fell through the cracks. Also fun fact, while implementing I discovered errors 
if the static strings, so glad we're doing it this way instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to