mbeckerle commented on a change in pull request #273: WIP: Add User Defined Functions Capability URL: https://github.com/apache/incubator-daffodil/pull/273#discussion_r335994206
########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/UserDefinedFunctionBase.scala ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.daffodil.dpath + +import org.apache.daffodil.exceptions.Assert +import java.lang.reflect.Method +import org.apache.daffodil.udf.UserDefinedFunction + +/** + * Both the evaluate method and the User Defined Function instance are passed in, as both are needed by the Method.invoke + * function. + */ +case class UserDefinedFunctionCall(recipes: List[CompiledDPath], userDefinedFunction: UserDefinedFunction, evaluateFxn: Method) + extends FNArgsList(recipes) { + override def computeValue(values: List[Any], dstate: DState) = { + val jValues = values.map { _.asInstanceOf[Object] } + val res = evaluateFxn.invoke(userDefinedFunction, jValues: _*) Review comment: I think we would need API features to make it sensible for a UDF to signal an SDE based on the UDF author's logic. Since these are pure functions, ... other than the scenarios we already check for, I'm not sure what other situations warrant a SDE. We already do the type-checking. I would suggest we not hold up this change set for that, and if we find we need SDE we change later. I think a PE makes more sense, and anything thrown by a UDF should become a Processing error (parse or unparse error... don't forget about unparse!) I think there is a constructor to create a PE from an Exception or Throwable directly. (If not there should be.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
