I'm currently going through the regression suite and making changes to
get all the tests to pass.
I think one problem is many of these schemas haven't been update in a
real long time, in some cases since daffodil 2.6.0. Some of the things
that have been removed went through a reasonable deprecation process and
are very minor changes now hat they've been removed.
I'll send a report of all the changes that I find to get the schemas
working with 3.5.0 and see if that helps determine if 4.0.0 is more
appropriate or 3.5.0 is fine.
On 2023-06-06 07:42 PM, Mike Beckerle wrote:
Topic: Should this be version 4.0.0, not 3.5.0?
The OGSI-package-name-changes have broken many schemas because the test
rigs used Daffodil internals, and some deprecated things were finally
removed in the current 3.5.0 snapshot.
But as a result, these schemas, many of which are non-public, but
nevertheless can be counted, a long list, which used to work, don't work
any more.
It's possible there are false-negatives here. Nevertheless it is a long
list.
[fail] (04/62) dfdl-bmp
[fail] (11/62) dfdl-examples-hexwords
[fail] (12/62) dfdl-examples-self-descriptive-data
[fail] (13/62) dfdl-examples-xslt-csv
[fail] (22/62) dfdl-imf-icalendar-cse
[fail] (23/62) dfdl-ipf-demo
[fail] (29/62) dfdl-jpeg2000
[fail] (30/62) dfdl-jreap
[fail] (34/62) dfdl-mil-std-2045
[fail] (38/62) dfdl-nitf
[fail] (42/62) dfdl-plc4x-s7
[fail] (43/62) dfdl-png
[fail] (46/62) dfdl-raster
[fail] (49/62) dfdl-stanag-5516
[fail] (50/62) dfdl-stanag-5516-with-nact
[fail] (53/62) dfdl-usmtf
[fail] (54/62) dfdl-usmtf-generic
[fail] (57/62) dfdl-vmf
[fail] (59/62) dfdl-vmf-spock
[fail] (61/62) ibm-dfdl-crosstester
This suggests to me that user-created schemas have some fairly high
likelihood of being clobbered.
We changed the packages of many things. We can claim these were internal
things, but there are many schemas that depend on Daffodil internal things
now. This needs to get fixed so we can torque the internals more without
breaking things, but right now... things are broken.
Every schema using layers, for example as we never hardened the API for
layers, so as it has evolved, schemas have broken.
On Mon, Jun 5, 2023 at 6:07 PM Mike Beckerle <mbecke...@apache.org> wrote:
All critical and blocker type bugs have been fixed including a couple
quite challenging ones in the last few weeks.
I think it is time to create an RC for 3.5.0.
Please discuss through 6pm EDT.US on Thursday June 8. (72 hours) and if
favorable we'll figure out who gets to create the RC.
-mikeb
Mike Beckerle
Apache Daffodil PMC | daffodil.apache.org
OGF DFDL Workgroup Co-Chair | www.ogf.org/ogf/doku.php/standards/dfdl/dfdl
Owl Cyber Defense | www.owlcyberdefense.com
