Oh, I didn't know about these release notes! I wish they were part of the extension repo also, tbh. I can see why they are published on the Daffodil site, but I would also like them incorporated or referenced in the docs, which are currently hosted on the extension GitHub wiki.
On Fri, Aug 25, 2023 at 11:40 AM Shane Dell <shaned...@apache.org> wrote: > I have a PR out on the daffodil-site repo, > https://github.com/apache/daffodil-site/pull/118, for > adding the 1.3.1 release page. Not sure if that is what you were referring > to or not Steve. I > do say it upgrades to Daffodil 3.5.0, but I can add the link to the > release information that > Steve provided. Also, I can add a note about this release only being able > to support schemas > that support Daffodil 3.5.0 or greater. > > > On 2023/08/25 17:56:16 Steve Lawrence wrote: > > For a little more detail, one of the backwards incompatible changes made > > in 3.5.0 was a few package renames to better support OSGI. This required > > that the META-INF/services file in the ethernetIP had to be renamed from > > > > org.apache.daffodil.layers.LayerCompiler > > > > to > > > > org.apache.daffodil.runtime1.layers.LayerCompiler > > > > Without this, Daffodil 3.5.0 can't find the layer. > > > > There's a number of other backwards incompatible/deprecation changes > > made in Daffodil 3.5.0, listed on the release notes page here: > > > > https://daffodil.apache.org/releases/3.5.0/#deprecationcompatibility > > > > Agreed that mentioning this in the VSCode release notes is a good idea. > > Maybe something about 1.3.1 only supporting schemas compatible with > > Daffodil 3.5.0, and pointing to the 3.5.0 release notes page for more > > details might be useful. > > > > Also, please create a release notes page for this release. Ideally this > > would be be done prior to the vote, since we should be checking and > > voting on the release notes as well. > > > > > > On 2023-08-25 01:09 PM, Adam Rosien wrote: > > > I suspect the dfdl-ethernetip-1.2.0.jar your launch.json is pointing > to was > > > built at the 1.2.0 git tag, and that jar file isn't compatible with > > > Daffodil 3.5.0. (Tag 1.2.0 uses Daffodil 3.2.1.) > > > > > > If you do a `sbt package` and point your launch.json to the jar file > under > > > the target directory, the 1.3.1 VSCode Daffodil extension will load it > > > correctly. > > > > > > Perhaps we can put something in the release notes about schemas > needing to > > > be recompiled with Daffodil 3.5.0 (if <some condition> holds). > > > > > > .. Adam > > > > > > On Fri, Aug 25, 2023 at 8:42 AM Adam Rosien <a...@rosien.net> wrote: > > > > > >> I see the same problem and will file an issue. I don't have any quick > > >> ideas why it is happening. > > >> > > >> .. Adam > > >> > > >> On Fri, Aug 25, 2023 at 7:45 AM Mike Beckerle <mbecke...@apache.org> > > >> wrote: > > >> > > >>> Not voting yet, because I am perhaps doing something simple wrong. > > >>> > > >>> I am getting nowhere fast: > > >>> > > >>> I am debugging PCAP with the ethernetIP dependency. From a > terminal,'sbt > > >>> clean test' works and all tests pass. This also populates > lib_managed which > > >>> is where the ethernetIP jar is found for the debug classpath. > > >>> > > >>> My newly created launch.json is attached. > > >>> > > >>> Here's the terminal output from trying to run a test. It seems to be > > >>> unable to deal with the jar dependency. > > >>> > > >>> bash-5.1$ export > > >>> > DAFFODIL_DEBUG_CLASSPATH=/home/mbeckerle/dataiti/opensource/DFDLSchemas/PCAP/lib_managed/jars/com.owlcyberdefense/dfdl-ethernetip/dfdl-ethernetip-1.2.0.jar > > >>> bash-5.1$ export DAFFODIL_DEBUG_LOG_LEVEL=INFO > > >>> bash-5.1$ export DAFFODIL_DEBUG_LOG_FILE=/tmp/daffodil-debugger.log > > >>> bash-5.1$ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 > > >>> bash-5.1$ > > >>> > /home/mbeckerle/.vscode/extensions/asf.apache-daffodil-vscode-1.3.1/daffodil-debugger-3.5.0-1.3.1/bin/daffodil-debugger > > >>> --listenPort 4711 > > >>> 2023-08-25 10:37:24,425 [io-compute-5] INFO o.a.d.d.d.DAPodil - > > >>> ****************************************************** > > >>> A DAP server for debugging Daffodil schema processors. > > >>> > > >>> Build info: > > >>> version: 1.3.1 > > >>> daffodilVersion: 3.5.0 > > >>> scalaVersion: 2.12.15 > > >>> sbtVersion: 1.8.2 > > >>> Runtime info: > > >>> JVM version: 1.8.0_382 (/usr/lib/jvm/java-8-openjdk-amd64/jre) > > >>> ****************************************************** > > >>> 2023-08-25 10:37:24,431 [io-compute-5] INFO o.a.d.d.d.DAPodil - > launched > > >>> with options listenPort: 4711, listenTimeout: 10 seconds > > >>> 2023-08-25 10:37:24,459 [io-compute-5] INFO o.a.d.d.d.DAPodil - > waiting > > >>> at tcp://localhost:4711 > > >>> 2023-08-25 10:37:26,835 [io-compute-blocker-5] INFO > o.a.d.d.d.DAPodil - > > >>> connected at tcp://localhost:4711 > > >>> 2023-08-25 10:37:27,148 [io-compute-3] INFO o.a.d.d.d.DAPSession - > R> #1 > > >>> initialize {"clientID":"vscode","clientName":"Visual Studio > > >>> > Code","adapterID":"dfdl","pathFormat":"path","linesStartAt1":true,"columnsStartAt1":true,"supportsVariableType":true,"supportsVariablePaging":true,"supportsRunInTerminalRequest":true,"locale":"en","supportsProgressReporting":true,"supportsInvalidatedEvent":true,"supportsMemoryReferences":true,"supportsArgsCanBeInterpretedByShell":true,"supportsMemoryEvent":true,"supportsStartDebuggingRequest":true} > > >>> > > >>> 2023-08-25 10:37:27,211 [io-compute-10] INFO o.a.d.d.d.DAPSession - > <R > > >>> #1 initialize success > > >>> > {"supportsConfigurationDoneRequest":true,"supportsHitConditionalBreakpoints":false,"supportsConditionalBreakpoints":false,"supportsEvaluateForHovers":false,"supportsCompletionsRequest":false,"supportsRestartFrame":false,"supportsSetVariable":false,"supportsRestartRequest":false,"supportTerminateDebuggee":false,"supportsDelayedStackTraceLoading":false,"supportsLogPoints":false,"supportsExceptionInfoRequest":false,"supportsDataBreakpoints":false,"supportsClipboardContext":false,"supportsLoadedSourcesRequest":false} > > >>> > > >>> 2023-08-25 10:37:27,217 [io-compute-blocker-10] INFO > > >>> o.a.d.d.d.DAPSession - <E initialized > > >>> 2023-08-25 10:37:27,219 [io-compute-6] INFO o.a.d.d.d.DAPSession - > R> #2 > > >>> launch > > >>> > {"request":"launch","type":"dfdl","name":"test1","program":"/home/mbeckerle/dataiti/opensource/DFDLSchemas/PCAP/src/main/resources/com/tresys/pcap/xsd/pcap.dfdl.xsd","data":"/home/mbeckerle/dataiti/opensource/DFDLSchemas/PCAP/src/test/resources/com/tresys/pcap/data/icmp.badMagicNum.cap","debugServer":4711,"infosetFormat":"xml","infosetOutput":{"type":"file","path":"/home/mbeckerle/dataiti/opensource/DFDLSchemas/PCAP/target/infoset.xml"},"trace":true,"stopOnEntry":true,"useExistingServer":false,"openHexView":true,"openInfosetView":true,"openInfosetDiffView":true,"daffodilDebugClasspath":"/home/mbeckerle/dataiti/opensource/DFDLSchemas/PCAP/lib_managed/jars/com.owlcyberdefense/dfdl-ethernetip/dfdl-ethernetip-1.2.0.jar","dataEditor":{"port":9000,"logging":{"file":"/home/mbeckerle/dataiti/opensource/DFDLSchemas/PCAP/dataEditor-${omegaEditPort}.log","level":"info"}},"dfdlDebugger":{"logging":{"file":"/tmp/daffodil-debugger.log","level":"INFO"}},"__configurationTarget":6,"__sessionId":"4ddfd218-3c35-477f-83ad-0fec46b6e502"} > > >>> > > >>> 2023-08-25 10:37:27,220 [io-compute-6] INFO o.a.d.d.d.DAPSession - > R> #3 > > >>> configurationDone null > > >>> 2023-08-25 10:37:32,779 [io-compute-3] ERROR o.a.d.d.d.DAPSession - > > >>> couldn't launch, request #2 launch > > >>> > {"request":"launch","type":"dfdl","name":"test1","program":"/home/mbeckerle/dataiti/opensource/DFDLSchemas/PCAP/src/main/resources/com/tresys/pcap/xsd/pcap.dfdl.xsd","data":"/home/mbeckerle/dataiti/opensource/DFDLSchemas/PCAP/src/test/resources/com/tresys/pcap/data/icmp.badMagicNum.cap","debugServer":4711,"infosetFormat":"xml","infosetOutput":{"type":"file","path":"/home/mbeckerle/dataiti/opensource/DFDLSchemas/PCAP/target/infoset.xml"},"trace":true,"stopOnEntry":true,"useExistingServer":false,"openHexView":true,"openInfosetView":true,"openInfosetDiffView":true,"daffodilDebugClasspath":"/home/mbeckerle/dataiti/opensource/DFDLSchemas/PCAP/lib_managed/jars/com.owlcyberdefense/dfdl-ethernetip/dfdl-ethernetip-1.2.0.jar","dataEditor":{"port":9000,"logging":{"file":"/home/mbeckerle/dataiti/opensource/DFDLSchemas/PCAP/dataEditor-${omegaEditPort}.log","level":"info"}},"dfdlDebugger":{"logging":{"file":"/tmp/daffodil-debugger.log","level":"INFO"}},"__configurationTarget":6,"__sessionId":"4ddfd218-3c35-477f-83ad-0fec46b6e502"} > > >>> > > >>> org.apache.daffodil.debugger.dap.Compiler$CompilationFailed: Schema > > >>> Definition Error: The dfdlx:layerTransform 'IPv4Checksum' was not > found. > > >>> Available choices are: lineFolded_iCalendar, base64_MIME, gzip, > > >>> fourbyteswap, lineFolded_IMF > > >>> Schema context: sequence[1] Location line 122 column 14 in > > >>> > jar:file:/home/mbeckerle-unencrypted/opensource/DFDLSchemas/PCAP/lib_managed/jars/com.owlcyberdefense/dfdl-ethernetip/dfdl-ethernetip-1.2.0.jar!/com/owlcyberdefense/dfdl/xsd/ethernetIP.dfdl.xsd > > >>> at > > >>> > org.apache.daffodil.debugger.dap.Compiler$$anon$1.$anonfun$compile$2(Compiler.scala:38) > > >>> at cats.MonadError.$anonfun$ensureOr$1(MonadError.scala:41) > > >>> at println @ > > >>> > com.monovore.decline.effect.CommandIOApp$.addVersionFlag(CommandIOApp.scala:67) > > >>> at ensureOr$extension @ > > >>> > org.apache.daffodil.debugger.dap.Compiler$$anon$1.compile(Compiler.scala:38) > > >>> at map @ > > >>> > org.apache.daffodil.debugger.dap.Compiler$$anon$1.compile(Compiler.scala:39) > > >>> at map @ > > >>> org.apache.daffodil.debugger.dap.Parse$.apply(Parse.scala:83) > > >>> at flatMap @ > > >>> org.apache.daffodil.debugger.dap.Parse$.apply(Parse.scala:81) > > >>> at println @ > > >>> > com.monovore.decline.effect.CommandIOApp$.addVersionFlag(CommandIOApp.scala:67) > > >>> at map @ > > >>> > org.apache.daffodil.debugger.dap.Parse$Debugee$LaunchArgs$Manual.data(Parse.scala:213) > > >>> at flatMap @ > > >>> > org.apache.daffodil.debugger.dap.Parse$.$anonfun$debugee$20(Parse.scala:677) > > >>> at unsafeRunSync @ > > >>> > org.apache.daffodil.debugger.dap.DAPSession$Server.dispatchRequest(DAPodil.scala:100) > > >>> at apply @ > > >>> > org.apache.daffodil.debugger.dap.DAPSession$.resource(DAPodil.scala:84) > > >>> at apply @ > > >>> > org.apache.daffodil.debugger.dap.DAPSession$.resource(DAPodil.scala:84) > > >>> at unsafeRunSync @ > > >>> > org.apache.daffodil.debugger.dap.DAPSession$Server.dispatchRequest(DAPodil.scala:100) > > >>> at apply @ > > >>> > org.apache.daffodil.debugger.dap.DAPSession$.resource(DAPodil.scala:84) > > >>> 2023-08-25 10:37:32,780 [io-compute-3] INFO o.a.d.d.d.DAPSession - > <E > > >>> daffodil.error.request > > >>> 2023-08-25 10:37:32,781 [io-compute-blocker-5] INFO > o.a.d.d.d.DAPSession > > >>> - <E terminated > > >>> 2023-08-25 10:37:32,782 [io-compute-blocker-5] INFO > o.a.d.d.d.DAPSession > > >>> - <R #3 configurationDone success null > > >>> 2023-08-25 10:37:32,849 [io-compute-1] INFO o.a.d.d.d.DAPSession - > R> #4 > > >>> disconnect {"restart":false} > > >>> 2023-08-25 10:37:32,851 [io-compute-7] INFO o.a.d.d.d.DAPSession - > R> #5 > > >>> threads null > > >>> 2023-08-25 10:37:32,852 [io-compute-5] INFO o.a.d.d.d.DAPSession - > <R #4 > > >>> disconnect success null > > >>> 2023-08-25 10:37:33,360 [io-compute-1] INFO o.a.d.d.d.DAPodil - > > >>> disconnected at tcp://localhost:4711 > > >>> bash-5.1$ > > >>> > > >>> > > >>> > > >>> On Thu, Aug 24, 2023 at 12:30 PM Shane Dell <shaned...@apache.org> > wrote: > > >>> > > >>>> Hello all,I'd like to call a vote to release Apache Daffodil VS Code > > >>>> 1.3.1-rc1. > > >>>> > > >>>> All distribution packages, including signatures, digests, etc. can > be > > >>>> found at: > > >>>> > https://dist.apache.org/repos/dist/dev/daffodil/daffodil-vscode/1.3.1-rc1 > > >>>> > > >>>> This release has been signed with PGP key > > >>>> 86DDE7B41291E380237934F007570D3ADC76D51B, corresponding > > >>>> to shaned...@apache.org, which is included in the KEYS file here: > > >>>> https://downloads.apache.org/daffodil/KEYS > > >>>> > > >>>> The release candidate has been tagged in git with 1.3.1-rc1. > > >>>> > > >>>> For reference, here is a list of all closed GitHub issues tagged > with > > >>>> 1.3.1: > > >>>> https://github.com/apache/daffodil-vscode/milestone/10?closed=1 > > >>>> > > >>>> Please review and vote. The vote will be open for at least 72 hours > > >>>> (Tuesday, 28 August 2023, 12:30pm EST). > > >>>> > > >>>> [ ] +1 approve > > >>>> [ ] +0 no opinion > > >>>> [ ] -1 disapprove (and reason why) > > >>>> > > >>>> Documentation for 1.3.1 can be found here > > >>>> > > >>>> > https://github.com/apache/daffodil-vscode/wiki/Apache-Daffodil%E2%84%A2-Extension-for-Visual-Studio-Code:-v1.3.1 > > >>>> . > > >>>> > > >>>> Thank you, > > >>>> > > >>>> - Shane Dell > > >>>> > > >>> > > > > > > > >
