My vote is -1. I found an issue, while testing and development for the data editor, that would render any byte with a binary value of 0x00 as "null" / "inoperable" in the data viewports.
This comes from a conditional when creating the elements to display byte values and it interpreting the value of said byte to be null. I have created and issue & and associated PR ( https://github.com/apache/daffodil-vscode/pull/828 ). I would like to get a second release candidate out that has a resolution for this issue, when the PR has the appropriate approvals. On 2023/08/24 16:30:27 Shane Dell wrote: > Hello all,I'd like to call a vote to release Apache Daffodil VS Code > 1.3.1-rc1. > > All distribution packages, including signatures, digests, etc. can be > found at: > https://dist.apache.org/repos/dist/dev/daffodil/daffodil-vscode/1.3.1-rc1 > > This release has been signed with PGP key > 86DDE7B41291E380237934F007570D3ADC76D51B, corresponding > to [email protected], which is included in the KEYS file here: > https://downloads.apache.org/daffodil/KEYS > > The release candidate has been tagged in git with 1.3.1-rc1. > > For reference, here is a list of all closed GitHub issues tagged with 1.3.1: > https://github.com/apache/daffodil-vscode/milestone/10?closed=1 > > Please review and vote. The vote will be open for at least 72 hours > (Tuesday, 28 August 2023, 12:30pm EST). > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > Documentation for 1.3.1 can be found here > https://github.com/apache/daffodil-vscode/wiki/Apache-Daffodil%E2%84%A2-Extension-for-Visual-Studio-Code:-v1.3.1. > > Thank you, > > - Shane Dell >
