jmalkin opened a new pull request #48: Python distribution URL: https://github.com/apache/incubator-datasketches-cpp/pull/48 I believe this gets everything ready to create a source distribution (sdist) tarball for python. But I'm not sure if there's an issue packaging the BSD-licensed pybind11 in the tarball with our code? We point to it as a submodule in git, which they suggest doing in their own cmake example, and they even say to use --recursive when cloning. But that's not necessarily the same as distributing it within our tarball. Since the current code doesn't work properly to create an artifact that can be pushed to python's package repository (pypi) I'm ok with it. But committing this change would make it much easier to upload something to there. So I'm kind of holding off until we get feedback on whether this approach is valid.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
