Ah yes. It turns out that the strict profile detects a false positive and fails :(. And there is no way to suppress that false positive with annotation. At line 100 in XxHash64Test.java, the multiplication (0x9C90005B80000000L * 2) is intentionally meant to overflow. The strict test, however, catches the overflow and declares it an error. I can rewrite it to eliminate the overflow, but it will make the test harder to understand.
On Mon, Jul 22, 2019 at 12:33 PM leerho <[email protected]> wrote: > Odd. Maven-jar-plugin 3.1.2 clearly exists on Maven Central: > https://search.maven.org/search?q=g:org.apache.maven.plugins%20AND%20a:maven-jar-plugin&core=gav > . > > Overriding the Apache Parent Pom is always an option and should work (At > least it does for me.). > > But sometimes when I experience problems like this I either run *mvn > install* or *mvn package*. This will force all dependencies into your > local .m2 repository. > > I'm not sure why you are having this issue, nevertheless, using 3.1.0 > should also work. > > *Profiles:* > There are only 2 profiles: > > - The *m2e* profile exists only to: > Ignore nuisance warning from Apache parent plugin: > "maven-remote-resources-plugin (goal "process") is ignored by m2e". This > also should fix the Maven warning that it can't find the lifecycle-mapping > jar. So you can ignore this one. > - The *strict* profile runs the org.codehaus.plexus : > plexus-compiler-javac-errorprone plugin. This compiler is more sensitive > to potential coding errors. You can run this as an option. I always do > prior to a release. > > > > > > > On Mon, Jul 22, 2019 at 11:38 AM Furkan KAMACI <[email protected]> > wrote: > >> Hi Leerho, >> >> Thanks for the links! >> >> I cannot compile the source code. I get that error: >> >> Plugin org.apache.maven.plugins:maven-jar-plugin:3.1.2 or one of its >> dependencies could not be resolved: Failure to find >> org.apache.maven.plugins:maven-jar-plugin:jar:3.1.2 in >> https://repo.maven.apache.org/maven2 was cached in the local repository, >> resolution will not be reattempted until the update interval of central has >> elapsed or updates are forced >> >> So, I've checked that this dependency extends the version at Apache Repo. >> I've set the version as 3.1.0 and it has started to compile. Do you have >> any idea about it? >> >> On the other hand, should I activate a profile while compiling and >> testing source code? >> >> Kind Regards, >> Furkan KAMACI >> >> On Mon, Jul 22, 2019 at 8:34 PM leerho <[email protected]> wrote: >> >>> If you are interested, the documentation for the DataSketches Memory >>> component is part of the website. >>> >>> Specifically: >>> - https://datasketches.github.io/docs/Memory/MemoryPackage.html >>> - https://datasketches.github.io/docs/Memory/MemoryPerformance.html >>> >>> Lee. >>> >>> On Mon, Jul 22, 2019 at 10:28 AM leerho <[email protected]> wrote: >>> >>>> A 500 error is a malformed link or some internal GitHub server error >>>> .... I don't get that error when just clicking on the link. >>>> >>>> When exactly are you getting that error message? >>>> >>>> >>>> >>>> >>>> On Mon, Jul 22, 2019 at 9:08 AM Furkan KAMACI <[email protected]> >>>> wrote: >>>> >>>>> Hi Leerho, >>>>> >>>>> GitHub throws a 500 error for this link: >>>>> >>>>> https://github.com/apache/incubator-datasketches-memory >>>>> >>>>> is that usual? >>>>> >>>>> Kind Regards, >>>>> Furkan KAMACI >>>>> >>>>> On Sun, Jul 21, 2019 at 9:33 PM leerho <[email protected]> wrote: >>>>> >>>>>> Note also that when running the test suite, you might get the >>>>>> following message: >>>>>> >>>>>> SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". >>>>>> SLF4J: Defaulting to no-operation (NOP) logger implementation >>>>>> SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for >>>>>> further details. >>>>>> >>>>>> This is normal. It just indicates that in your environment, you do >>>>>> not have a logger in your class-path so the default logger of a >>>>>> *no-op* is used instead. >>>>>> >>>>>> On Sat, Jul 20, 2019 at 8:52 AM leerho <[email protected]> wrote: >>>>>> >>>>>>> The DataSketches-memory component is pure Java and is structured as >>>>>>> a Maven project. You must compile using JDK 8. The simplest way is to >>>>>>> import the unzipped code into Eclipse or equivalent IDE as a Maven >>>>>>> Project. There is one run-time dependency and, of course, a number of >>>>>>> test >>>>>>> and Maven plugin dependencies, all of which will be resolved by your >>>>>>> IDE. >>>>>>> >>>>>>> This component is a set of low-level library functions that is used >>>>>>> by the other DataSketches components. It has no user interface so the >>>>>>> only >>>>>>> thing you can do is compile and run the unit tests. Unless, of course, >>>>>>> you >>>>>>> are interested in the actual functions of the Memory and are willing to >>>>>>> write code that calls the Memory functions. >>>>>>> >>>>>>> This particular component has been split out from the rest of the >>>>>>> DataSketches code because there have been a number of requests from >>>>>>> folks >>>>>>> that are interested in these high-performance functions independently of >>>>>>> the remainder of the DataSketches library. >>>>>>> >>>>>>> Lee. >>>>>>> >>>>>>> >>>>>>> On Fri, Jul 19, 2019 at 7:24 PM Liang Chen <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> Hi >>>>>>>> >>>>>>>> Please provide the build guide, how to compile source code. >>>>>>>> >>>>>>>> Regards >>>>>>>> Liang >>>>>>>> >>>>>>>> leerho <[email protected]> 于2019年7月20日周六 上午10:05写道： >>>>>>>> >>>>>>>> > Hello Apache DataSketches Community, >>>>>>>> > >>>>>>>> > 1. This is a call for vote to release Apache DataSketches-memory >>>>>>>> version: >>>>>>>> > 1.0.0-incubating-RC1 >>>>>>>> > >>>>>>>> > NOTE 1: This is one component of the DataSketches library which >>>>>>>> needs to >>>>>>>> > be released first as other >>>>>>>> > repositories have a dependency on this one. Once this is >>>>>>>> released, the >>>>>>>> > other components of the library >>>>>>>> > will be able to be released. >>>>>>>> > >>>>>>>> > NOTE 2: All of the code has been properly refactored with >>>>>>>> > "org.apache.datasketches...". >>>>>>>> > All source files have the proper Apache license and have been >>>>>>>> checked with >>>>>>>> > the Maven Rat Plugin. >>>>>>>> > The code passes all tests with a coverage of > 98%. >>>>>>>> > >>>>>>>> > 2. The release candidate: >>>>>>>> > >>>>>>>> > >>>>>>>> https://dist.apache.org/repos/dist/dev/incubator/datasketches/memory/1.0.0-incubating-RC1/apache-datasketches-memory-1.0.0-incubating-RC1-src.zip >>>>>>>> > >>>>>>>> > 3. Source repository: >>>>>>>> > https://github.com/apache/incubator-datasketches-memory >>>>>>>> > >>>>>>>> > Git Tag for this release: >>>>>>>> > >>>>>>>> > >>>>>>>> https://github.com/apache/incubator-datasketches-memory/tree/1.0.0-incubating-RC1 >>>>>>>> > >>>>>>>> > Git HashId for this release starts with: 966f9bf >>>>>>>> > >>>>>>>> > The artifacts have been signed with --keyid-format SHORT : >>>>>>>> 8CD4A902 >>>>>>>> > >>>>>>>> > 4. Repository: dist.apache.org repository: >>>>>>>> > >>>>>>>> > The public signing key can be found in the KEYS file: >>>>>>>> > >>>>>>>> https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS >>>>>>>> > >>>>>>>> > Upon acceptance, the above artifacts will be deployed into the >>>>>>>> official >>>>>>>> > Apache release repository: >>>>>>>> > >>>>>>>> https://dist.apache.org/repos/dist/release/incubator/datasketches/memory/ >>>>>>>> > >>>>>>>> > 5. Repository: Maven Central (repository.apache.org): >>>>>>>> > >>>>>>>> > Upon acceptance the jar artifacts will be generated from the >>>>>>>> source >>>>>>>> > repository and deployed >>>>>>>> > to the Apache Maven Central staging repository: >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> https://repository.apache.org/content/groups/staging/org/apache/datasketches/memory/ >>>>>>>> > >>>>>>>> > And then released into >>>>>>>> > >>>>>>>> > >>>>>>>> https://repository.apache.org/content/repositories/releases/datasketches/memory/ >>>>>>>> > >>>>>>>> > 6. The vote will be open for at least 72 hours or until necessary >>>>>>>> number >>>>>>>> > of votes are reached. >>>>>>>> > >>>>>>>> > Please vote accordingly: >>>>>>>> > >>>>>>>> > [ ] +1 approve >>>>>>>> > [ ] +0 no opinion >>>>>>>> > [ ] -1 disapprove with the reason >>>>>>>> > >>>>>>>> > Thanks, >>>>>>>> > The Apache DataSketches Team >>>>>>>> > >>>>>>>> >>>>>>>
